Issue 236130043: Issue 4386: Part_combine_iterator: move mmrest handling outside the part-routing state machine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 236130043: Issue 4386: Part_combine_iterator: move mmrest handling outside the part-routing state machine (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 12 months ago by Dan Eble

Modified:
8 years, 11 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 1

Created: 8 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -8 lines)			Patch
	M	lily/part-combine-iterator.cc	View		6 chunks	+20 lines, -8 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Dan Eble

8 years, 12 months ago (2015-05-11 02:52:21 UTC) #1

https://codereview.appspot.com/236130043/diff/1/lily/part-combine-iterator.cc
File lily/part-combine-iterator.cc (left):

https://codereview.appspot.com/236130043/diff/1/lily/part-combine-iterator.cc...
lily/part-combine-iterator.cc:236: kill_mmrest (CONTEXT_SHARED);
Here is the one difference worth pointing out.  The new code does not kill
mmrests in the shared voice in this case.  I have been unable to think of a
scenario in which this makes a difference.

Expand All Messages | Collapse All Messages