Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7854)

Issue 235320044: Rework LY_DECLARE_SMOB_PROC to declare a member function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by dak
Modified:
8 years, 10 months ago
Reviewers:
Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Rework LY_DECLARE_SMOB_PROC to declare a member function This is nicer to work with. LY_DECLARE_SMOB_PROC now needs to additionally get the class name for declaring the smob procedure: this is astonishingly hard to avoid. Moving the initialization out of Smob_base<Super>::init into a separate routine smob_proc_init defined by LY_DECLARE_SMOB_PROC considerably simplifies the initialization.

Patch Set 1 #

Patch Set 2 : Overhaul doc and interface of LY_DECLARE_SMOB_PROC. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -33 lines) Patch
M lily/include/listener.hh View 1 2 chunks +6 lines, -6 lines 0 comments Download
M lily/include/smobs.hh View 1 2 chunks +36 lines, -19 lines 0 comments Download
M lily/include/smobs.tcc View 1 chunk +1 line, -6 lines 0 comments Download
M lily/unpure-pure-container.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2
dak
Overhaul doc and interface of LY_DECLARE_SMOB_PROC.
8 years, 11 months ago (2015-05-17 11:54:59 UTC) #1
Dan Eble
8 years, 11 months ago (2015-05-17 18:21:49 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b