avoid ssl_eof error on SSL_WANT_READ and friends

lib/DJabberd/Stanza/StartTLS.pm

 package DJabberd::Stanza::StartTLS;
 use strict;
 use base qw(DJabberd::Stanza);
 use Net::SSLeay;
 
 Net::SSLeay::load_error_strings();
 Net::SSLeay::SSLeay_add_ssl_algorithms();
 Net::SSLeay::randomize();
 
 use constant SSL_ERROR_WANT_READ     => 2;
@@ skipping 51 matching lines @@
         warn "SSL accept error on $conn\n";
         $conn->close;
         return;
     }
 
     warn "$conn:  Cipher `" . Net::SSLeay::get_cipher($ssl) . "'\n";
 
     $conn->set_writer_func(DJabberd::Stanza::StartTLS->danga_socket_writerfunc($conn));
 }
 
-sub should_we_close_on_zero_bytes {
+sub actual_error_on_empty_read {
     my ($class, $ssl) = @_;
-    my $err = Net::SSLeay::get_error($ssl,-1);

[bradfitz, 2008/06/19 20:45:39]

space after comma

[Jacob, 2008/06/23 18:48:27]

On 2008/06/19 20:45:39, bradfitz wrote:
> space after comma

Done.

+    my $err = Net::SSLeay::get_error($ssl, -1);
     if ($err == SSL_ERROR_WANT_READ || 
         $err == SSL_ERROR_WANT_WRITE || 
         $err == SSL_ERROR_WANT_CONNECT || 
         $err == SSL_ERROR_WANT_ACCEPT) {
-        # No, don't close on zero bytes, SSL is busy doing something like renegotiating encryption
+        # Not an actual error, SSL is busy doing something like renegotiating encryption
         # just try again next time
         return 0;
     }
-    # Yes, close on zero bytes
-    # this is an SSL err code unlike the 'no-op' WANT_READ and WANT_WRITE
+    # This is actually an error (return the SSL err code)
+    # unlike the 'no-op' WANT_READ and WANT_WRITE
     return $err;

[bradfitz, 2008/06/19 20:45:39]

Does this function return a boolean or an error code?  The name suggests a
boolean, but the return value suggests an error code.

[Jacob, 2008/06/23 18:48:27]

On 2008/06/19 20:45:39, bradfitz wrote:
> Does this function return a boolean or an error code?  The name suggests a
> boolean, but the return value suggests an error code.
> 

Both! It returns an error code or zero, and the return value is used as if it
were a boolean in the if check in Connection to decide if we should close or not
close.  If we should close, we want to log the error code, so we log the value
returned.... I've changed the function name to actual_error_on_empty_read, is
that better?  Open to suggestions.

 }
 
 
 sub danga_socket_writerfunc {
     my ($class, $conn) = @_;
     my $ssl = $conn->{ssl};
     return sub {
         my ($bref, $to_write, $offset) = @_;
 
         # unless our event_read has been called, we don't want to try
@@ skipping 30 matching lines @@
             return 0;
         }
 
         return $written;
     };
 }
 
 1;
 
 #  LocalWords:  conn