Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 2338043: Clear errno to 0 before calling strtol/strtoul. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by Daiki Ueno
Modified:
13 years, 5 months ago
Reviewers:
shawn.p.huang, Peng Huang
Base URL:
git@github.com:ibus/ibus-m17n.git
Visibility:
Public.

Description

Clear errno to 0 before calling strtol/strtoul. To handle errors of strtol/strtoul correctly, errno should be cleared beforehand. BUG=none TEST=manual

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/m17nutil.c View 1 chunk +10 lines, -5 lines 0 comments Download
M src/setup.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
Daiki Ueno
13 years, 5 months ago (2010-10-07 07:16:52 UTC) #1
Peng Huang
13 years, 5 months ago (2010-10-27 06:45:20 UTC) #2
On 2010/10/07 07:16:52, daiki.ueno wrote:
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b