Issue 2333042: Container level filter in SlingMainServlet

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2333042: Container level filter in SlingMainServlet

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by Ian Boston

Modified:
14 years, 9 months ago

Reviewers:
justinedelson, fmeschbe

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -1 line)			Patch
	M	bundles/engine/src/main/java/org/apache/sling/engine/impl/SlingMainServlet.java	View		3 chunks	+30 lines, -0 lines	2 comments	Download
	M	bundles/engine/src/main/java/org/apache/sling/engine/impl/filter/ServletFilterManager.java	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

justinedelson

http://codereview.appspot.com/2333042/diff/1/bundles/engine/src/main/java/org/apache/sling/engine/impl/SlingMainServlet.java File bundles/engine/src/main/java/org/apache/sling/engine/impl/SlingMainServlet.java (right): http://codereview.appspot.com/2333042/diff/1/bundles/engine/src/main/java/org/apache/sling/engine/impl/SlingMainServlet.java#newcode176 bundles/engine/src/main/java/org/apache/sling/engine/impl/SlingMainServlet.java:176: public void doService(ServletRequest req, ServletResponse res) throws ServletException { ...

14 years, 9 months ago (2010-09-30 15:00:02 UTC) #1

fmeschbe

14 years, 9 months ago (2010-10-01 06:25:13 UTC) #2

http://codereview.appspot.com/2333042/diff/1/bundles/engine/src/main/java/org...
File
bundles/engine/src/main/java/org/apache/sling/engine/impl/SlingMainServlet.java
(right):

http://codereview.appspot.com/2333042/diff/1/bundles/engine/src/main/java/org...
bundles/engine/src/main/java/org/apache/sling/engine/impl/SlingMainServlet.java:176:
public void doService(ServletRequest req, ServletResponse res) throws
ServletException {
On 2010/09/30 15:00:02, justinedelson wrote:
> should this method really be public? seems more likely it should be private or
> at least package private.

Agreed, I would go for package private (to not incurr the cost of a synthetic
method added).

Expand All Messages | Collapse All Messages