Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(875)

Issue 233300043: Issue 4372: convert-ly misses some bflat -> b-flat (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 12 months ago by dak
Modified:
8 years, 10 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4372: convert-ly misses some bflat -> b-flat In python/convert-rules.py, using '\b' for note name boundaries turns out to be too audacious since bflat4 is one word. A proper solution would be to match the variable wordsyntax and let the match expression use a replacement function that triggers on the right words. However, such a large number of matches would be expensive. So instead we are using positive lookahead and lookbehind expressions to get reasonably good matches.

Patch Set 1 #

Patch Set 2 : Actually, we can score 100% #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M python/convertrules.py View 1 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 2
lemzwerg
LGTM.
8 years, 12 months ago (2015-05-10 19:04:18 UTC) #1
dak
8 years, 12 months ago (2015-05-11 08:26:52 UTC) #2
Actually, we can score 100%
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b