Use mkstemp for intermediate ps files

Use mkstemp for intermediate ps files

When backend is `ps' (default),
intermediate ps files are created by mkstemp.

The following issues are fixed.

Filename issue (to compile lines.ly, gs_init.ly etc.)
Intermediate file issue (to overwrite and delete .ps file)

[pkx166h, 2015-05-07 08:39:37]

This fails a make check (reg test comparison)

--snip--
Renaming input to: `/tmp/lilypond-autobuild/input/regression/fret-boards.ly'
Interpreting music...
Preprocessing graphical objects...
Calculating line breaks... 
Drawing systems... 
Writing header field `texidoc' to `./2d/lily-6db94e9b.texidoc'...
Writing ./2d/lily-6db94e9b-1.signature
Layout output to
`./2d/lily-6db94e9b.eps'.../tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/backend-library.scm:161:16:
In procedure eval in expression (eval (string->symbol #) module):
/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/backend-library.scm:161:16:
Unbound variable: convert-to-eps

--snip--

and

--snip--

Renaming input to:
`/tmp/lilypond-autobuild/input/regression/lyric-melisma-melisma.ly'
Interpreting music...
Preprocessing graphical objects...
Calculating line breaks... 
Drawing systems... 
Writing header field `texidoc' to `./4f/lily-9d452b57.texidoc'...
Writing ./4f/lily-9d452b57-1.signature
Layout output to
`./4f/lily-9d452b57.eps'.../tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/backend-library.scm:161:16:
In procedure eval in expression (eval (string->symbol #) module):
/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/backend-library.scm:161:16:
Unbound variable: convert-to-eps

--snip--

there are a few more but it looks like the same issue

[trueroad, 2015-05-07 14:29:12]

Add checking formats

[lemzwerg, 2015-05-07 14:54:02]

From reading the code, without testing, LGTM.

If possible, please apply this rather large patch in smaller commits so that it
becomes more readable.

Thanks for working on this!

https://codereview.appspot.com/233230044/diff/20001/scm/backend-library.scm
File scm/backend-library.scm (right):

https://codereview.appspot.com/233230044/diff/20001/scm/backend-library.scm#n...
scm/backend-library.scm:142: ;; includeing unicode.
s/includeing/including/
s/unicode/Unicode/

[trueroad, 2015-05-07 15:58:21]

Fix the comment's typo

[trueroad, 2015-05-07 16:05:58]

> If possible, please apply this rather large patch in smaller commits so that
it
> becomes more readable.

At least, I'll divide about PLATFORM variable changing.

>
https://codereview.appspot.com/233230044/diff/20001/scm/backend-library.scm#n...
> scm/backend-library.scm:142: ;; includeing unicode.
> s/includeing/including/
> s/unicode/Unicode/

I've fixed.

Thank you.

[pkx166h, 2015-05-07 17:20:48]

Still fails make doc

--snip--

GNU LilyPond 2.19.20

Forking into jobs:  (13125 13124 13123 13122 13121 13120)
logfile lilypond-multi-run-3.log (exit 1):
. #<Mom 0>) 4 . #<Mom 0>)]
In
/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/framework-ps.scm:
 635: 24* [clip-systems-to-region
"./e3/lily-7756f0eb-1-from-2.0.1-to-4.0.1-clip" ...]
 591: 25  (let* (# #) (for-each # extents-system-pairs))
 601: 26  [for-each #<procedure #f (ext-system-pair)> ((# . #))]
In unknown file:
   ?: 27* [#<procedure #f (ext-system-pair)> (# . #)]
In
/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/framework-ps.scm:
 603: 28* (let* ((xext #) (paper-system #) (yext #) ...) (set! count (1+ count))
...)
 617: 29* (if do-pdf (postscript->pdf 0 0 (format #f "~a.eps" filename) #f))
 618: 30  [postscript->pdf 0 0 ...]

/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/framework-ps.scm:618:14:
In procedure postscript->pdf in expression (postscript->pdf 0 0 ...):
/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/framework-ps.scm:618:14:
Wrong number of arguments to #<procedure postscript->pdf (paper-width
paper-height base-name tmp-name is-eps)>
fatal error: Children (3) exited with errors.


--snip--

[pkx166h, 2015-05-07 17:22:20]

On 2015/05/07 17:20:48, J_lowe wrote:
> Still fails make doc
> 
> --snip--
> 
> GNU LilyPond 2.19.20
> 
> Forking into jobs:  (13125 13124 13123 13122 13121 13120)
> logfile lilypond-multi-run-3.log (exit 1):
> . #<Mom 0>) 4 . #<Mom 0>)]
> In
> /tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/framework-ps.scm:
>  635: 24* [clip-systems-to-region
> "./e3/lily-7756f0eb-1-from-2.0.1-to-4.0.1-clip" ...]
>  591: 25  (let* (# #) (for-each # extents-system-pairs))
>  601: 26  [for-each #<procedure #f (ext-system-pair)> ((# . #))]
> In unknown file:
>    ?: 27* [#<procedure #f (ext-system-pair)> (# . #)]
> In
> /tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/framework-ps.scm:
>  603: 28* (let* ((xext #) (paper-system #) (yext #) ...) (set! count (1+
count))
> ...)
>  617: 29* (if do-pdf (postscript->pdf 0 0 (format #f "~a.eps" filename) #f))
>  618: 30  [postscript->pdf 0 0 ...]
> 
>
/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/framework-ps.scm:618:14:
> In procedure postscript->pdf in expression (postscript->pdf 0 0 ...):
>
/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/framework-ps.scm:618:14:
> Wrong number of arguments to #<procedure postscript->pdf (paper-width
> paper-height base-name tmp-name is-eps)>
> fatal error: Children (3) exited with errors.
> 
> 
> --snip--

Just to add, it seems to fail make doc quite quickly (so if this log isn't
helping you may want to try a make, make doc and see if you can debug it
locally).

Usually make doc can take a long time, and only fail near the end - but this
seems to fail relatively quickly.

James

[trueroad, 2015-05-08 02:54:11]

Fix `-dclip-systems'

[trueroad, 2015-05-08 02:59:28]

> Just to add, it seems to fail make doc quite quickly (so if this log isn't
> helping you may want to try a make, make doc and see if you can debug it
> locally).
> 
> Usually make doc can take a long time, and only fail near the end - but this
> seems to fail relatively quickly.

I've fixed.
I've succeeded `make doc'.
Thank you.

[pkx166h, 2015-05-08 13:45:25]

On 2015/05/08 02:59:28, trueroad wrote:
> > Just to add, it seems to fail make doc quite quickly (so if this log isn't
> > helping you may want to try a make, make doc and see if you can debug it
> > locally).
> > 
> > Usually make doc can take a long time, and only fail near the end - but this
> > seems to fail relatively quickly.
> 
> I've fixed.
> I've succeeded `make doc'.
> Thank you.

Passes all tests now.

Patch is on review

Thanks

James

[trueroad, 2015-05-09 15:17:19]

Divide and improve the patch

[trueroad, 2015-05-09 15:21:53]

I've divided and improved the patch.


  Issue 4374 / 1: Fix platform identification

    On Cygwin environment,
    Guile's uname returns the strings of "CYGWIN_NT-6.3" etc.
    It contains unnecessary strings for the platform identification,
    such as Windows version.

    Therefore, to remove them to return the only "cygwin".


  Issue 4374 / 2: Add make-tmpfile procedure

    Procedure "make-tmpfile" is
    to create a unique temporary file using "mkstemp!".


  Issue 4374 / 3: Add copy-binary-file procedure

    Procedure "copy-binary-file" is
    to copy a binary file correctly on any platforms.


  Issue 4374 / 4: Use mkstemp for intermediate ps files

    When backend is `ps' (default),
    intermediate ps files are created by mkstemp.

    The following issues are fixed.

    Filename issue (to compile lines.ly, gs_init.ly etc.)
    Intermediate file issue (to overwrite and delete .ps file)

[lemzwerg, 2015-05-12 04:59:14]

LGTM

[pkx166h, 2015-05-12 10:19:40]

Patch on countdown for May 16th

[pkx166h, 2015-05-16 06:40:04]

Patch counted down - please push

[trueroad, 2015-05-16 13:12:19]

I've pushed.

Issue 4374 / 1: Fix platform identification

author    Masamichi Hosoda <trueroad@trueroad.jp>
Sat, 9 May 2015 08:20:19 +0000 (17:20 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
Sat, 16 May 2015 11:56:31 +0000 (20:56 +0900)
commit    e2eb72d3d2070a3888df1f7e7907798833965baa

Issue 4374 / 2: Add make-tmpfile procedure

author    Masamichi Hosoda <trueroad@trueroad.jp>
Sat, 16 May 2015 11:46:55 +0000 (20:46 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
Sat, 16 May 2015 11:56:31 +0000 (20:56 +0900)
commit    7de09b0cc440a37fc3755c54f29f7b47371401d9

Issue 4374 / 3: Add copy-binary-file procedure

author    Masamichi Hosoda <trueroad@trueroad.jp>
Sat, 9 May 2015 13:29:14 +0000 (22:29 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
Sat, 16 May 2015 11:56:31 +0000 (20:56 +0900)
commit    042f66eec99633a5d1d60e8fc2daa15cc433666a

Issue 4374 / 4: Use mkstemp for intermediate ps files

author    Masamichi Hosoda <trueroad@trueroad.jp>
Sat, 9 May 2015 13:49:14 +0000 (22:49 +0900)
committer Masamichi Hosoda <trueroad@trueroad.jp>
Sat, 16 May 2015 11:56:32 +0000 (20:56 +0900)
commit    67fc9ed5450a20215c4dbefa86f6f8b388bbdb92