Partcombiner documentation (Issue 4307)

Adds a section documenting the use of the optional argument to the partcombiner

[PhilEHolmes, 2015-05-02 14:20:29]

Please review

[Trevor Daniels, 2015-05-02 17:34:32]

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simult...
File Documentation/notation/simultaneous.itely (right):

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simult...
Documentation/notation/simultaneous.itely:931: @notation{a due} note, and
separates notes more than a ninth apart into
For the avoidance of doubt, perhaps insert here:

@notation{a due} note, combines notes less than a ninth apart with the same
rhythm as chords, and separates ...

Otherwise, LGTM.

[Keith, 2015-05-03 05:19:13]

Looks fine.

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simult...
File Documentation/notation/simultaneous.itely (right):

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simult...
Documentation/notation/simultaneous.itely:937: a second or more, setting it to
one splits notes of a third or more, and so one.
Extra 'e' on "and so on".

You might turn around the order of explanation so you don't have to translate
between interval names and number of scale steps, but just let the example show
it.

"A pair of numbers placed as an option after @code{\partcombine} controls the
range of intervals between the parts for which the partcombiner may merge the
parts.  The numbers in the pair specify the number of scale-steps by which the
first part is higher in pitch than the second part.  The default range is from
0~steps (a unison) to 8~steps (a ninth)."

Dan wondered whether to make 2 represent a second, etc.,
 https://codereview.appspot.com/144170043/#msg14
but the code treats inverted intervals in a continuous way, so counting scale
steps seemed more natural.

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simult...
Documentation/notation/simultaneous.itely:941: c4 d e f |
Starting at a, will clarify what happens when the parts cross

[PhilEHolmes, 2015-05-03 12:24:16]

Thanks for the comments.

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simult...
File Documentation/notation/simultaneous.itely (right):

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simult...
Documentation/notation/simultaneous.itely:931: @notation{a due} note, and
separates notes more than a ninth apart into
On 2015/05/02 17:34:32, Trevor Daniels wrote:
> For the avoidance of doubt, perhaps insert here:
> 
> @notation{a due} note, combines notes less than a ninth apart with the same
> rhythm as chords, and separates ...
> 
> Otherwise, LGTM.

Done.

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simult...
Documentation/notation/simultaneous.itely:937: a second or more, setting it to
one splits notes of a third or more, and so one.
On 2015/05/03 05:19:13, Keith wrote:
> Extra 'e' on "and so on".
> 
> You might turn around the order of explanation so you don't have to translate
> between interval names and number of scale steps, but just let the example
show
> it.

I decided to give examples of what value corresponded to what interval, since
the way it's been implemented actually seemed counterintuitive to me and I had
to check what was actually going on in my example.  Given this, I thought being
explicit was best.

https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simult...
Documentation/notation/simultaneous.itely:941: c4 d e f |
On 2015/05/03 05:19:13, Keith wrote:
> Starting at a, will clarify what happens when the parts cross

Done.

[PhilEHolmes, 2015-05-03 12:24:44]

Updates following comments from Keith and Trevor

[Trevor Daniels, 2015-05-03 12:48:30]

Good point, Phil.  Perhaps we should slightly amend the text too to cover this
feature, as shown.

Trevor

https://codereview.appspot.com/233110043/diff/20001/Documentation/notation/si...
File Documentation/notation/simultaneous.itely (right):

https://codereview.appspot.com/233110043/diff/20001/Documentation/notation/si...
Documentation/notation/simultaneous.itely:932: rhythm as chords and separates
notes more than a ninth apart into
... ninth apart or when the voices cross into separate ...

[PhilEHolmes, 2015-05-03 13:04:14]

Updated following Trevor's latest suggestion

[Trevor Daniels, 2015-05-03 16:06:55]

LGTM.

Trevor