Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1852)

Issue 2328041: Made the API of shader translator library consistent.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by Alok Priyadarshi
Modified:
13 years, 7 months ago
Reviewers:
kbr1, dgkoch, nicolas
CC:
angleproject-review_googlegroups.com, gmanchromium
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Made the API of shader translator library consistent. - We recently started using OpenGL-type enums. This CL makes all old enums consistent with the new scheme. - Renamed TBuiltInResource to ShBuiltInResources to have a consistent prefix BUG=46

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -223 lines) Patch
M include/GLSLANG/ShaderLang.h View 1 2 7 chunks +86 lines, -82 lines 0 comments Download
M samples/translator/translator.cpp View 1 2 10 chunks +30 lines, -30 lines 0 comments Download
M src/compiler/CodeGenGLSL.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/CodeGenHLSL.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/Compiler.cpp View 1 2 6 chunks +22 lines, -11 lines 0 comments Download
M src/compiler/Initialize.h View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M src/compiler/Initialize.cpp View 1 2 9 chunks +20 lines, -17 lines 0 comments Download
M src/compiler/OutputHLSL.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/ParseHelper.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/ParseHelper.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ShHandle.h View 1 4 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/ShaderLang.cpp View 1 2 6 chunks +9 lines, -8 lines 0 comments Download
M src/compiler/TranslatorGLSL.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/TranslatorGLSL.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/TranslatorHLSL.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/TranslatorHLSL.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/VariableInfo.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/VariableInfo.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/glslang.y View 3 chunks +18 lines, -40 lines 0 comments Download
M src/libGLESv2/Shader.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7
Alok Priyadarshi
13 years, 7 months ago (2010-09-30 04:45:51 UTC) #1
kbr1
I am not sure that this is the right direction to go with the API. ...
13 years, 7 months ago (2010-09-30 17:31:16 UTC) #2
dgkoch
Yes, I'm inclined to agree with KBR here. The TBuiltInResource->ShBuiltInResources change seems logical, but replacing ...
13 years, 7 months ago (2010-09-30 17:50:00 UTC) #3
Alok Priyadarshi
Makes sense. I was not too inclined to change enums to int either. My main ...
13 years, 7 months ago (2010-09-30 21:45:27 UTC) #4
Alok Priyadarshi
I have kept the enums. Just made the naming convention of enums and enum values ...
13 years, 7 months ago (2010-10-01 17:36:58 UTC) #5
dgkoch
no issues this round. Daniel
13 years, 7 months ago (2010-10-01 20:48:09 UTC) #6
kbr1
13 years, 7 months ago (2010-10-01 21:10:34 UTC) #7
Looks much better.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b