Issue 2323043: Proposed fix for SHINDIG-1436: Shindig does not support returning a JSON array when format 'json'

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2323043: Proposed fix for SHINDIG-1436: Shindig does not support returning a JSON array when format 'json' (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by henry.saputra

Modified:
13 years ago

Reviewers:
Paul Lindner, johnfargo, dev-remailer

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Based on OpenSocial 1.0 spec[1] the osapi.http.get() or <os:HttpRequest> could return JSON object or array for format JSON. The review contains proposed fix for jira SHINDIG-1436 to check the first character. If its '[' then try to build JSON array, otherwise create JSON object. Updated the unit test accordingly. [1] http://opensocial-resources.googlecode.com/svn/spec/1.0/Core-Data.xml#rfc.section.2.9

Patch Set 1 #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -2 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpRequestHandler.java	View		2 chunks	+8 lines, -1 line	0 comments	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HttpRequestHandlerTest.java	View		2 chunks	+22 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Paul Lindner

lgtm -- not sure about the larger protocol implications, but I think we're fine there ...

13 years, 6 months ago (2010-09-30 11:18:23 UTC) #2

johnfargo

lgtm On Thu, Sep 30, 2010 at 4:18 AM, <lindner@inuus.com> wrote: > lgtm -- not ...

13 years, 6 months ago (2010-09-30 15:32:42 UTC) #3

henry.saputra

13 years, 6 months ago (2010-09-30 17:11:27 UTC) #4

Thanks for the review guys,

Fixed with svn revision 1003169

- Henry

On 2010/09/30 15:32:42, johnfargo wrote:
> lgtm
> 
> On Thu, Sep 30, 2010 at 4:18 AM, <mailto:lindner@inuus.com> wrote:
> 
> > lgtm -- not sure about the larger protocol implications, but I think
> > we're fine there too.
> >
> >
> >
> > http://codereview.appspot.com/2323043/
> >

Expand All Messages | Collapse All Messages