Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15961)

Issue 232190043: Issue 4357: Next rebase of upload. Should actually be quite the same (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 12 months ago by dak
Modified:
8 years, 10 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4357: Next rebase of upload. Should actually be quite the same as the version before last rebase since issue 4373 now is in the race as a substitute for the ill-fated and reverted issue 4360 and can get reviewed in parallel with this one as there are no merge/rebase conflicts between the two. Remove Scheme listeners as they are just callbacks now. Reimplement Listener around generic SCM callback and instance Run preparatory script replacing listener macros This script is for i in $(git grep -l 'IMPLEMENT_LISTENER (') do sed -i '/IMPLEMENT_LISTENER ([^)]*$/{N;s/\n\s*/ /}' $i sedscript=$(git grep -h 'IMPLEMENT_LISTENER (' $i| sed 's|^.*IMPLEMENT_LISTENER (\([^,]*\), \([^)]*\)).*$|s/GET_LISTENER (\\([_a-z]\\+->\\)\\?\2)/\\1GET_LISTENER (\1, \2)/|') sed -i "$sedscript" $i done sed -i '/IMPLEMENT_LISTENER (/d' $(git grep -l 'IMPLEMENT_LISTENER (') sed -i 's/DECLARE_LISTENER (\([^)]*\));\?/void \1 (SCM);/' $(git grep -l 'DECLARE_LISTENER (') Make dispatchers callable for dispatching Move self_scm_ into non-templated Smob_core base class.

Patch Set 1 #

Patch Set 2 : Fold in simple version of issue 4576 #

Patch Set 3 : Replace all the translator_listener_record stuff with Scheme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -526 lines) Patch
M lily/context.cc View 8 chunks +7 lines, -13 lines 0 comments Download
M lily/dispatcher.cc View 7 chunks +16 lines, -10 lines 0 comments Download
M lily/dispatcher-scheme.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M lily/engraver-group.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M lily/global-context.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M lily/grace-engraver.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M lily/include/context.hh View 2 chunks +6 lines, -6 lines 0 comments Download
M lily/include/dispatcher.hh View 1 chunk +3 lines, -2 lines 0 comments Download
M lily/include/engraver-group.hh View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/include/global-context.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/lily-guile-macros.hh View 1 1 chunk +18 lines, -1 line 0 comments Download
M lily/include/listener.hh View 1 2 1 chunk +140 lines, -71 lines 0 comments Download
M lily/include/scheme-engraver.hh View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
D lily/include/scheme-listener.hh View 1 chunk +0 lines, -41 lines 0 comments Download
M lily/include/score-engraver.hh View 1 chunk +3 lines, -3 lines 0 comments Download
M lily/include/score-performer.hh View 1 chunk +3 lines, -3 lines 0 comments Download
M lily/include/smobs.hh View 1 3 chunks +15 lines, -4 lines 0 comments Download
M lily/include/translator.hh View 1 2 4 chunks +13 lines, -31 lines 0 comments Download
M lily/include/translator.icc View 1 2 2 chunks +8 lines, -23 lines 0 comments Download
M lily/include/translator-group.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/lily-guile.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M lily/listener.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M lily/lyric-combine-music-iterator.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M lily/midi-control-function-performer.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M lily/part-combine-iterator.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M lily/scheme-engraver.cc View 1 2 5 chunks +5 lines, -62 lines 0 comments Download
D lily/scheme-listener.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D lily/scheme-listener-scheme.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M lily/score-engraver.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M lily/score-performer.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M lily/smobs.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M lily/translator.cc View 1 2 3 chunks +22 lines, -32 lines 0 comments Download
M lily/translator-group.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M scm/part-combiner.scm View 1 chunk +27 lines, -29 lines 0 comments Download
M scm/scheme-engravers.scm View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2
dak
Fold in simple version of issue 4576
8 years, 12 months ago (2015-05-07 11:56:19 UTC) #1
dak
8 years, 12 months ago (2015-05-07 14:01:46 UTC) #2
Replace all the translator_listener_record stuff with Scheme
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b