Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2954)

Issue 232180043: Document incipit command (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by PhilEHolmes
Modified:
8 years, 12 months ago
Reviewers:
pkx166h, dak, Trevor Daniels, mail
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Docstring and index entries added

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Documentation/notation/ancient.itely View 1 chunk +2 lines, -0 lines 1 comment Download
M ly/property-init.ly View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7
PhilEHolmes
Please review
9 years ago (2015-05-04 11:27:12 UTC) #1
Trevor Daniels
One suggestion, otherwise LGTM. https://codereview.appspot.com/232180043/diff/1/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/232180043/diff/1/Documentation/notation/ancient.itely#newcode2651 Documentation/notation/ancient.itely:2651: @funindex incipit @cindex entries too?
9 years ago (2015-05-05 11:43:26 UTC) #2
mail_philholmes.net
----- Original Message ----- From: <tdanielsmusic@googlemail.com> To: <PhilEHolmes@googlemail.com>; <dak@gnu.org>; <pkx166h@gmail.com> Cc: <reply@codereview-hr.appspotmail.com>; <lilypond-devel@gnu.org> Sent: Tuesday, ...
9 years ago (2015-05-05 12:07:32 UTC) #3
Trevor Daniels
On 2015/05/05 12:07:32, mail_philholmes.net wrote: > I read the CG on *index entries, and experimented ...
9 years ago (2015-05-05 13:09:15 UTC) #4
dak
On 2015/05/05 13:09:15, Trevor Daniels wrote: > On 2015/05/05 12:07:32, http://mail_philholmes.net wrote: > > > ...
9 years ago (2015-05-05 13:20:02 UTC) #5
dak
On 2015/05/05 13:09:15, Trevor Daniels wrote: > On 2015/05/05 12:07:32, http://mail_philholmes.net wrote: > > > ...
9 years ago (2015-05-05 13:22:56 UTC) #6
mail_philholmes.net
9 years ago (2015-05-05 14:59:28 UTC) #7
----- Original Message ----- 
From: <tdanielsmusic@googlemail.com>

> So in addition to your two entries I would suggest adding
>
> @cindex incipits, adding
>
> or some such.
>
> Trevor


OK - done that on my local copy here.  It compiles fine, so I'm not 
proposing to upload it for further review.

--
Phil Holmes 

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b