Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(676)

Issue 232130043: Issue 3687 (part 4): Update regression tests to use \compressMMRests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by Trevor Daniels
Modified:
9 years ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 3687 (part 4): Update regression tests to use \compressMMRests Issue 3687 (part 3) Update snippets to use \compressMMRests Issue 3687 (part 2): Amend docs to use \compressMMRests Amend the examples in the LM and NR to use the \compressMMRests music function rather than the predefs \compressFullBarRests and \expandFullBarRests to avoid advocating the use of techniques which may have undesirable side effects. Issue 3687 (part 1): Provide a compress MM function for MM rests only Multi-measure rests were previously compressed (i.e. all bars following the first were removed) by using the \compressFullBarRests predef. This simply turned on 'skipBars, which causes bar lines at the ends of bars which contain either no rhythmic event or contain a rhythmic event with a duration extending beyond the bar to be removed. Such bars are generated by notes with durations longer than a bar, like a1*3, or by shorter notes which extend beyond the bar. This patch provides a function which also uses 'skipBars, but with a filter so that 'skipBars is activated only when an actual MM rest is encountered and deactivated by the first following rhythmic event. Issue 3687 (part 0): run convert-ly Run convert-ly on the doc files to be changed to bring them up to date.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -182 lines) Patch
M Documentation/learning/fundamental.itely View 5 chunks +17 lines, -13 lines 0 comments Download
M Documentation/notation/changing-defaults.itely View 2 chunks +8 lines, -7 lines 0 comments Download
M Documentation/notation/rhythms.itely View 9 chunks +41 lines, -43 lines 0 comments Download
M Documentation/snippets/changing-form-of-multi-measure-rests.ly View 2 chunks +6 lines, -5 lines 0 comments Download
M Documentation/snippets/forcing-measure-width-to-adapt-to-metronomemarks-width.ly View 2 chunks +8 lines, -7 lines 0 comments Download
M Documentation/snippets/multi-measure-rest-markup.ly View 2 chunks +11 lines, -10 lines 0 comments Download
A + Documentation/snippets/new/changing-form-of-multi-measure-rests.ly View 2 chunks +8 lines, -12 lines 0 comments Download
A Documentation/snippets/new/forcing-measure-width-to-adapt-to-metronomemarks-width.ly View 1 chunk +33 lines, -0 lines 0 comments Download
A + Documentation/snippets/new/multi-measure-rest-markup.ly View 2 chunks +13 lines, -17 lines 0 comments Download
A + Documentation/snippets/new/positioning-multi-measure-rests.ly View 3 chunks +4 lines, -9 lines 0 comments Download
A + Documentation/snippets/new/vocal-headword.ly View 3 chunks +4 lines, -9 lines 0 comments Download
A + Documentation/snippets/new/wind-headword.ly View 4 chunks +5 lines, -12 lines 0 comments Download
M Documentation/snippets/positioning-multi-measure-rests.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/vocal-headword.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/snippets/wind-headword.ly View 3 chunks +3 lines, -5 lines 0 comments Download
M input/regression/make-relative.ly View 3 chunks +5 lines, -5 lines 0 comments Download
M input/regression/part-combine-mmrest-shared.ly View 1 chunk +4 lines, -4 lines 0 comments Download
M input/regression/rest-positioning.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/tablature-full-notation.ly View 2 chunks +19 lines, -18 lines 0 comments Download
M ly/music-functions-init.ly View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Trevor Daniels
9 years ago (2015-05-06 17:11:37 UTC) #1
Message was sent while issue was closed.
Pushed to staging as

Pushed to staging as five commits:

Part 0: run convert-ly
ca016880c383a964f3d3542cfba64ada0e1d41cd
Part 1: Provide a compress MM function for MM rests only
689f63e0473f8325b63d6bba66f9a56335548303
Part 2: Amend docs to use \compressMMRests
ba9a8dc730bb3a681455150bc0a3eef0976523af
Part 3: Update snippets to use \compressMMRests
f509f0d4df0b7d4336d904ca61902ad67dc2be5e
Part 4: Update regression tests to use \compressMMRests
be72b961ab5c4f6ade95e962c872babf7b0338a0

Closing ...

Trevor
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b