Issue 2318041: Python Issue 9873 - bytes in urllib.parse

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2318041: Python Issue 9873 - bytes in urllib.parse

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Nick Coghlan

Modified:
13 years, 6 months ago

Reviewers:
Antoine Pitrou

Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+173 lines, -91 lines)			Patch
	M	Lib/test/test_urlparse.py	View		6 chunks	+36 lines, -10 lines	0 comments	Download
	M	Lib/urllib/parse.py	View		10 chunks	+137 lines, -81 lines	2 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Antoine Pitrou

13 years, 6 months ago (2010-09-29 21:18:08 UTC) #1

Overall the patch looks ok, although I can't say the implementation strategy
makes for very readable code.

(I would suggest to temporarily decode bytes using latin1, but the properties on
ResultMixin wouldn't make that very pretty either)

http://codereview.appspot.com/2318041/diff/1/Lib/urllib/parse.py
File Lib/urllib/parse.py (right):

http://codereview.appspot.com/2318041/diff/1/Lib/urllib/parse.py#newcode48
Lib/urllib/parse.py:48: uses_params = ['ftp', 'hdl', 'prospero', 'http', 'imap',
Not directly related to the patch, but shoudn't all these lists be sets? It
would speed up containment tests quite a bit.

http://codereview.appspot.com/2318041/diff/1/Lib/urllib/parse.py#newcode139
Lib/urllib/parse.py:139: __slots__ = ()
Again, not related to the patch, but ResultMixin lacks a __slots__, so
SplitResult will have a __dict__ anyway.

Expand All Messages | Collapse All Messages