Issue 231300043: Allow ImageMagick's compare to exit with status 1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 231300043: Allow ImageMagick's compare to exit with status 1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 12 months ago by dak

Modified:
8 years, 10 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Allow ImageMagick's compare to exit with status 1 Apparently Ubuntu 15.04 has a version of "compare" that cannot be easily persuaded to return anything but exit status 1 (which indicates dissimilar images but no actual error condition) so we allow this in script/build/output-distance.py in order to keep "make check" from failing. This patch is somewhat artless but does the trick.

Patch Set 1 #

Patch Set 2 : Python's os.system scales return values by 256. Ugh. #

Patch Set 3 : Don't allow death by signal #

Created: 8 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	scripts/build/output-distance.py	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Don't allow death by signal

Expand All Messages | Collapse All Messages