Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 2303044: Rename vertical spacing dimensions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 6 months ago by Mark Polesky
Modified:
14 years, 4 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Rename vertical spacing dimensions.

Patch Set 1 #

Patch Set 2 : Update convertrules, regtests, and English docs. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -141 lines) Patch
M Documentation/notation/spacing.itely View 7 chunks +29 lines, -29 lines 1 comment Download
M input/regression/page-breaking-min-distance.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/page-breaking-title-padding.ly View 1 chunk +4 lines, -4 lines 0 comments Download
M input/regression/page-breaking-title-padding2.ly View 1 chunk +4 lines, -4 lines 0 comments Download
M input/regression/page-breaking-title-padding3.ly View 1 chunk +4 lines, -4 lines 0 comments Download
M input/regression/page-spacing-loose-lines-between.ly View 1 chunk +6 lines, -5 lines 0 comments Download
M input/regression/page-spacing-loose-lines-header-padding.ly View 3 chunks +3 lines, -3 lines 0 comments Download
M input/regression/page-spacing-top-system-spacing.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/page-spacing-top-title-spacing.ly View 1 chunk +8 lines, -7 lines 0 comments Download
M input/regression/paper-nested-override.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/stem-length-estimation.ly View 2 chunks +4 lines, -5 lines 0 comments Download
M input/regression/system-overstrike.ly View 2 chunks +4 lines, -3 lines 0 comments Download
M lily/constrained-breaking.cc View 1 3 chunks +27 lines, -27 lines 0 comments Download
M lily/include/constrained-breaking.hh View 1 1 chunk +7 lines, -7 lines 0 comments Download
M lily/page-breaking.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M lily/page-layout-problem.cc View 1 6 chunks +22 lines, -22 lines 0 comments Download
M ly/paper-defaults-init.ly View 1 1 chunk +7 lines, -7 lines 0 comments Download
M python/convertrules.py View 1 chunk +13 lines, -1 line 0 comments Download
M scm/page.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/paper-system.scm View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1
Graham Percival (old account)
14 years, 5 months ago (2010-10-11 17:06:01 UTC) #1
With regards to convert-ly, it would be nice to run it on the translations.  But
as long as the doc build still works, don't manually change anything in the
translations.

I'll be writing up policies for convert-ly later this evening or tomorrow.


For the regtests, just go ahead and rename them.  Any regressions in those files
in 2.13.36 won't be picked up automatically, but I think we have enough eyes on
the spacing stuff right now that this isn't a huge loss.  If you want to be
totally safe, then check those specific regtests manually in the official
2.13.36 release.

http://codereview.appspot.com/2303044/diff/2001/Documentation/notation/spacin...
File Documentation/notation/spacing.itely (right):

http://codereview.appspot.com/2303044/diff/2001/Documentation/notation/spacin...
Documentation/notation/spacing.itely:11: @c \version "2.12.0"
I expected convert-ly to update this number.  Did you deliberately suppress (or
revert) that change, or is convert-ly broken?  :(

In either case, please update the version number here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b