Issue 229680043: Redefine LY_ASSERT_SMOB to deal with inherited is_smob

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 229680043: Redefine LY_ASSERT_SMOB to deal with inherited is_smob (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 12 months ago by dak

Modified:
8 years, 10 months ago

Reviewers:
Dan Eble

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Redefine LY_ASSERT_SMOB to deal with inherited is_smob When LY_ASSERT_SMOB is called with a class that is actually derived from some smobified base class providing is_smob and unsmob, the resulting check and error message is inaccurate. This patch uses dynamic_cast in order to sustain sensible behavior. The performance impact for previously working code and type combinations is low since dynamic_cast in this configuration resolves at compile time.

Patch Set 1 #

Patch Set 2 : Be more conservative by defining a separate LY_ASSERT_DERIVED_SMOB #

Created: 8 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -1 line)			Patch
	M	lily/include/lily-guile-macros.hh	View	1	1 chunk	+18 lines, -1 line	0 comments	Download
	M	lily/lily-guile.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dak

Be more conservative by defining a separate LY_ASSERT_DERIVED_SMOB

8 years, 12 months ago (2015-05-07 09:56:54 UTC) #2

Dan Eble

8 years, 12 months ago (2015-05-07 12:26:23 UTC) #3

On 2015/05/07 09:56:54, dak wrote:
> Be more conservative by defining a separate LY_ASSERT_DERIVED_SMOB

Still LGTM.  I'll use this when I resume work on
https://code.google.com/p/lilypond/issues/detail?id=4365.

Expand All Messages | Collapse All Messages