Issue 2279043: Address senorblanco's comments on r600.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2279043: Address senorblanco's comments on r600. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by Steve VanDeBogart

Modified:
14 years, 2 months ago

Reviewers:
Stephen White

CC:
skia-review_googlegroups.com

Visibility:
Public.

Description

Address senorblanco's comments on r600. Don't inline constructors and destructors. Include license in test file. A few nits Also, cleanup a couple compile warnings. Committed: http://code.google.com/p/skia/source/detail?r=601

Patch Set 1 #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -29 lines)			Patch
M	include/pdf/SkPDFCatalog.h	View	1 chunk	+4 lines, -8 lines	0 comments	Download
M	include/pdf/SkPDFTypes.h	View	10 chunks	+19 lines, -19 lines	0 comments	Download
M	src/pdf/SkPDFCatalog.cpp	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/pdf/SkPDFTypes.cpp	View	10 chunks	+20 lines, -2 lines	0 comments	Download
M	tests/PDFPrimitivesTest.cpp	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Steve VanDeBogart

Thanks for the comments, addressed in this CL.

14 years, 2 months ago (2010-09-28 17:56:41 UTC) #1

LGTM

Expand All Messages | Collapse All Messages