Issue 2263041: - Moved the implementation for ShCompile to the compiler class so that intern...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2263041: - Moved the implementation for ShCompile to the compiler class so that intern... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by Alok Priyadarshi

Modified:
13 years, 12 months ago

Reviewers:
kbr1, dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

- Moved the implementation for ShCompile to the compiler class so that internal details about compiler can be encapsulated. Now we do not need to expose built-in symbol table. - Fixed a few const violations. - Added CollectAttribsUniforms class. BUG=26

Patch Set 1 #

Total comments: 3

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+315 lines, -176 lines)			Patch
M	src/build_angle.gyp	View	2 chunks	+3 lines, -0 lines	0 comments	Download
A	src/compiler/Compiler.cpp	View	1 chunk	+158 lines, -0 lines	3 comments	Download
M	src/compiler/Intermediate.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/ParseHelper.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/ShHandle.h	View	3 chunks	+27 lines, -13 lines	0 comments	Download
M	src/compiler/ShaderLang.cpp	View	3 chunks	+3 lines, -143 lines	0 comments	Download
M	src/compiler/TranslatorGLSL.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/compiler/TranslatorGLSL.cpp	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/compiler/TranslatorHLSL.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/compiler/TranslatorHLSL.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
A	src/compiler/VariableInfo.h	View	1 chunk	+38 lines, -0 lines	0 comments	Download
A	src/compiler/VariableInfo.cpp	View	1 chunk	+54 lines, -0 lines	0 comments	Download
M	src/compiler/glslang.l	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/localintermediate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/preprocessor/compile.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/compiler/preprocessor/preprocess.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/preprocessor/scanner.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/preprocessor/scanner.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/translator_common.vcproj	View	3 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Alok Priyadarshi

http://codereview.appspot.com/2263041/diff/1/src/compiler/Compiler.cpp File src/compiler/Compiler.cpp (right): http://codereview.appspot.com/2263041/diff/1/src/compiler/Compiler.cpp#newcode11 src/compiler/Compiler.cpp:11: static bool InitializeSymbolTable( This is exactly copied from ShaderLang.cpp ...

14 years ago (2010-09-21 19:23:09 UTC) #1

no issues here

Expand All Messages | Collapse All Messages