Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(653)

Issue 224800043: Add sans-serif and monospace fonts

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years ago by trueroad
Modified:
8 years, 11 months ago
Reviewers:
wl, c_sorensen, lemzwerg, dak, pkx166h, trueroad, simon.albrecht
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add sans-serif and monospace fonts Nimbus Sans L (Helvetica substitute) as sans-serif font. Nimbus Mono L (Courier substitute) as monospace font.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Integrate fonts dir configure options #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -13 lines) Patch
M config.make.in View 1 1 chunk +2 lines, -0 lines 0 comments Download
M configure.ac View 1 4 chunks +63 lines, -7 lines 0 comments Download
M mf/GNUmakefile View 4 chunks +35 lines, -1 line 0 comments Download
M scm/font.scm View 2 chunks +4 lines, -4 lines 0 comments Download
A + scripts/auxiliar/pfx2ttf-mono.fontforge View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 29
pkx166h
Patch on countdown for April 3rd
9 years ago (2015-03-31 09:37:52 UTC) #1
dak
Shouldn't we rather be selecting the Courier and Helvetica fonts (standard PostScript) and rely on ...
9 years ago (2015-03-31 15:57:54 UTC) #2
c_sorensen
On 2015/03/31 15:57:54, dak wrote: > Shouldn't we rather be selecting the Courier and Helvetica ...
9 years ago (2015-03-31 22:18:11 UTC) #3
dak
On 2015/03/31 22:18:11, c_sorensen wrote: > On 2015/03/31 15:57:54, dak wrote: > > Shouldn't we ...
9 years ago (2015-04-01 05:33:59 UTC) #4
trueroad
On 2015/04/01 05:33:59, dak wrote: > On 2015/03/31 22:18:11, c_sorensen wrote: > > On 2015/03/31 ...
9 years ago (2015-04-01 10:35:03 UTC) #5
dak
On 2015/04/01 10:35:03, trueroad wrote: > On 2015/04/01 05:33:59, dak wrote: > > On 2015/03/31 ...
8 years, 12 months ago (2015-04-01 18:46:34 UTC) #6
wl_gnu.org
>> Moreover, in my experiment, pango can't handle the ligature of >> PostScript Type1 font ...
8 years, 12 months ago (2015-04-02 04:29:07 UTC) #7
pkx166h
This looks like this still needs some review - I'll leave this on countdown for ...
8 years, 12 months ago (2015-04-03 13:02:31 UTC) #8
trueroad
On 2015/04/02 04:29:07, wl_gnu.org wrote: > >> Moreover, in my experiment, pango can't handle the ...
8 years, 12 months ago (2015-04-05 04:00:43 UTC) #9
pkx166h
Patch counted down - but at David K's request (and dev agreement) this will not ...
8 years, 12 months ago (2015-04-06 12:49:01 UTC) #10
dak
https://codereview.appspot.com/224800043/diff/1/config.make.in File config.make.in (right): https://codereview.appspot.com/224800043/diff/1/config.make.in#newcode97 config.make.in:97: COUR_DIR = @COUR_DIR@ It seems a bit excessive to ...
8 years, 11 months ago (2015-04-07 16:04:27 UTC) #11
dak
https://codereview.appspot.com/224800043/diff/1/scripts/auxiliar/pfx2ttf-mono.fontforge File scripts/auxiliar/pfx2ttf-mono.fontforge (right): https://codereview.appspot.com/224800043/diff/1/scripts/auxiliar/pfx2ttf-mono.fontforge#newcode17 scripts/auxiliar/pfx2ttf-mono.fontforge:17: # Monospace font shouldn't have these ligature. The file ...
8 years, 11 months ago (2015-04-07 16:07:49 UTC) #12
lemzwerg
> Wouldn't it make more sense to have one setting for all > of the ...
8 years, 11 months ago (2015-04-07 18:19:25 UTC) #13
trueroad
On 2015/04/07 16:07:49, dak wrote: > https://codereview.appspot.com/224800043/diff/1/scripts/auxiliar/pfx2ttf-mono.fontforge > File scripts/auxiliar/pfx2ttf-mono.fontforge (right): > > https://codereview.appspot.com/224800043/diff/1/scripts/auxiliar/pfx2ttf-mono.fontforge#newcode17 > ...
8 years, 11 months ago (2015-04-08 11:03:28 UTC) #14
trueroad
On 2015/04/07 18:19:25, lemzwerg wrote: > > Wouldn't it make more sense to have one ...
8 years, 11 months ago (2015-04-08 11:05:32 UTC) #15
trueroad
Integrate fonts dir configure options
8 years, 11 months ago (2015-04-08 13:44:05 UTC) #16
trueroad_sea.plala.or.jp
> I'll integrate the font directory specified options. > For example, > from --with-ncsb-dir, --with-helv-dir, ...
8 years, 11 months ago (2015-04-08 14:09:34 UTC) #17
pkx166h
Passes make, make check and a full make doc. Reg test diffs here: https://drive.google.com/file/d/0B9nZ5LHV2Ds6R3pUdHNpMkhVZEU/view?usp=sharing
8 years, 11 months ago (2015-04-08 16:45:37 UTC) #18
dak
On 2015/04/08 16:45:37, J_lowe wrote: > Passes make, make check and a full make doc. ...
8 years, 11 months ago (2015-04-08 18:07:06 UTC) #19
lemzwerg
> I like the current overall look for _this_ choice of fonts > better afterwards ...
8 years, 11 months ago (2015-04-08 20:18:55 UTC) #20
dak
On 2015/04/08 20:18:55, lemzwerg wrote: > > I like the current overall look for _this_ ...
8 years, 11 months ago (2015-04-09 05:14:59 UTC) #21
lemzwerg
> Letting PostScript ask for Helvetica which will let GhostScript > fall back to the ...
8 years, 11 months ago (2015-04-09 05:32:28 UTC) #22
simon.albrecht
Am 09.04.2015 um 07:14 schrieb dak@gnu.org: > On 2015/04/08 20:18:55, lemzwerg wrote: >> > I ...
8 years, 11 months ago (2015-04-09 09:01:44 UTC) #23
dak
Simon Albrecht <simon.albrecht@mail.de> writes: > Am 09.04.2015 um 07:14 schrieb dak@gnu.org: >> On 2015/04/08 20:18:55, ...
8 years, 11 months ago (2015-04-09 09:36:33 UTC) #24
pkx166h
OK this still needs discussion I think. I'll leave it on review.
8 years, 11 months ago (2015-04-12 10:06:27 UTC) #25
dak
On 2015/04/12 10:06:27, J_lowe wrote: > OK this still needs discussion I think. I'll leave ...
8 years, 11 months ago (2015-04-12 10:20:42 UTC) #26
pkx166h
Patch on countdown for April 18th
8 years, 11 months ago (2015-04-15 22:42:27 UTC) #27
pkx166h
Patch counted down - please push
8 years, 11 months ago (2015-04-18 08:43:13 UTC) #28
pkx166h
8 years, 11 months ago (2015-04-18 14:17:02 UTC) #29
author	Masamichi Hosoda <trueroad@sea.plala.or.jp>	
	Sat, 18 Apr 2015 14:10:06 +0000 (15:10 +0100)
committer	James Lowe <pkx166h@gmail.com>	
	Sat, 18 Apr 2015 14:15:18 +0000 (15:15 +0100)
commit	af1b0da3853670ee559e148cea70535d5f6ac716
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b