Issue 2235043: Don't init IBusBus in print_engines_xml().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2235043: Don't init IBusBus in print_engines_xml(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Daiki Ueno

Modified:
13 years, 7 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus-m17n.git

Visibility:
Public.

Description

Don't init IBusBus in print_engines_xml(). Bus initialization in print_engines_xml is not necessary, as Peng suggested in: http://github.com/ibus/ibus-m17n/commit/f52ba533eb86baa427df9107dd01670a85d17ab1#L6R78 BUG=none TEST=Manual

Patch Set 1 #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/main.c	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Peng

13 years, 7 months ago (2010-09-21 04:15:44 UTC) #2

On 2010/09/21 04:14:20, daiki.ueno wrote:
> 

LGTM - look good to me.

Expand All Messages | Collapse All Messages