Issue 2233046: Built-in string for vertex shaders can be empty. Nicolas handled this case in...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2233046: Built-in string for vertex shaders can be empty. Nicolas handled this case in... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by Alok Priyadarshi

Modified:
14 years, 11 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Built-in string for vertex shaders can be empty. Nicolas handled this case in r433 but r437 overwrote it.

Patch Set 1 #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	src/compiler/Compiler.cpp	View		1 chunk	+5 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dgkoch

I don't understand your comment about this being overwritten. r433 doesn't have any code like ...

14 years, 11 months ago (2010-09-23 23:42:21 UTC) #2

Alok Priyadarshi

14 years, 11 months ago (2010-09-24 05:18:01 UTC) #3

Nicolas made a similar change in ShaderLang.cpp in r433. I moved some stuff from
ShaderLang.cpp to Compiler.cpp in r437. I did not merge his change properly.
This fixes the merge error.

Expand All Messages | Collapse All Messages