Issue 2229048: Add codereview.settings.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2229048: Add codereview.settings. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by Peng

Modified:
14 years ago

Reviewers:
Yusuke Sato, satorux, satorux1

Base URL:
git@github.com:phuang/ibus-pinyin.git

Visibility:
Public.

Description

Add codereview.settings. This is for us to use codereview.appspot.com for code reviews. Instructions to use codereview.appspot.com: 1. Get depot_tools and add PATH to the directory http://dev.chromium.org/developers/how-tos/depottools 2. In your local IBus git repository, % git checkout master % git checkout -b somefix make changes % git cl upload do code reviews at codereview.appspot.com once it's done, run "git cl push" if you can commit. otherwise, ask committers to commit on behalf. Add target for build debian packages. BUG=none TEST=build fine

Patch Set 1 #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	Makefile.am	View		1 chunk	+12 lines, -0 lines	0 comments	Download
	A	codereview.settings	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

Add codereview setting file. Also add a make target for generating debian packages.

14 years ago (2010-09-26 11:00:17 UTC) #1

Yusuke Sato

lgtm On 2010/09/26 11:00:17, Shawn.P.Huang wrote: > Add codereview setting file. > Also add a ...

14 years ago (2010-09-27 02:08:39 UTC) #2

satorux1

14 years ago (2010-09-27 02:28:25 UTC) #3

LGTM for codereview.settings,

but would be nicer to change Makeifle.am in a separate patch.

On 2010/09/27 02:08:39, Yusuke Sato wrote:
> lgtm
> On 2010/09/26 11:00:17, Shawn.P.Huang wrote:
> > Add codereview setting file.
> > Also add a make target for generating debian packages.

Expand All Messages | Collapse All Messages