I hope this will fix a generateMipmaps crash when needRenderTarget fails....

I hope this will fix a generateMipmaps crash when needRenderTarget fails.

This fixes this crash in 7.0.524.0 on a user's Windows XP service pack 3 box.

0x014946f3 	[libGLESv2.dll 	- texture.cpp:1382] 	gl::Texture2D::generateMipmaps()
0x0149786f 	[libGLESv2.dll 	- libglesv2.cpp:2114] 	glGenerateMipmap
0x01c53199 	[chrome.dll 	- gles2_cmd_decoder.cc:2437] 	gpu::gles2::GLES2DecoderImpl::DoGenerateMipmap(unsigned int)
0x01c52216 	[chrome.dll 	- gles2_cmd_decoder.cc:2214] 	gpu::gles2::GLES2DecoderImpl::DoCommand(unsigned int,unsigned int,void const *)
0x01c4fa78 	[chrome.dll 	- cmd_parser.cc:56] 	gpu::CommandParser::ProcessCommand()
0x01c4f8ba 	[chrome.dll 	- gpu_processor.cc:100] 	gpu::GPUProcessor::ProcessCommands()
0x01ecdcce 	[chrome.dll 	- callback.h:119] 	CallbackImpl<BrowsingDataRemover,void ( BrowsingDataRemover::*)(void),Tuple0>::RunWithParams(Tuple0 const &)
0x01c4f2d9 	[chrome.dll 	- callback.h:79] 	CallbackRunner<Tuple0>::Run()
0x01c4edce 	[chrome.dll 	- command_buffer_service.cc:80] 	gpu::CommandBufferService::Flush(int)
0x01d6b9b1 	[chrome.dll 	- gpu_command_buffer_stub.cc:129] 	GpuCommandBufferStub::OnFlush(int,gpu::CommandBuffer::State *)

This might be glGenerateMipmaps after a device lost.

[apatrick1, 2010-09-16 21:36:18]

I found another needRenderTarget crash in our database. Can you take look?

Thanks

Al

[dgkoch, 2010-09-17 20:01:04]

On 2010/09/16 21:36:18, apatrick1 wrote:
> I found another needRenderTarget crash in our database. Can you take look?
> 

Seems likely.  Again don't forget to get TextureCubeMap::generateMipmaps at the
same time.

Daniel