Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(140)

Issue 2226048: code review 2226048: gc: Allow omission of types from embedded composite lit... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by rog
Modified:
14 years, 11 months ago
Reviewers:
r, rsc, gri
CC:
golang-dev, gustavo_niemeyer.ne
Visibility:
Public.

Description

gc: Allow omission of types from embedded composite literals. Prompted by the recent discussion on golang-nuts, this changeset implements Gustavo Niemeyer's proposal for reducing redundancy in nested composite literals. As you can see, the added complexity is not great.

Patch Set 1 #

Patch Set 2 : code review 2226048: gc: Allow omission of types from embedded composite lit... #

Patch Set 3 : code review 2226048: gc: Allow omission of types from embedded composite lit... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -20 lines) Patch
M doc/go_spec.html View 3 chunks +6 lines, -3 lines 0 comments Download
M src/cmd/gc/go.y View 5 chunks +16 lines, -9 lines 0 comments Download
M src/cmd/gc/typecheck.c View 1 7 chunks +36 lines, -8 lines 0 comments Download

Messages

Total messages: 2
rog
Hello r, gri, rsc (cc: golang-dev@googlegroups.com, gustavo@niemeyer.ne), I'd like you to review this change.
14 years, 11 months ago (2010-09-28 11:59:26 UTC) #1
rog
14 years, 11 months ago (2010-10-15 17:15:21 UTC) #2
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b