Issue 221660043: code review 221660043: compiler: discard carriage returns in raw string literals

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 221660043: code review 221660043: compiler: discard carriage returns in raw string literals

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years ago by minux

Modified:
9 years ago

Reviewers:
iant

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

compiler: discard carriage returns in raw string literals Fixes golang/go#10407.

Patch Set 1 #

Patch Set 2 : diff -r 2f1e891805e6ab6c326d565b8c0a3a7dadbac60c https://code.google.com/p/gofrontend #

Patch Set 3 : diff -r 2f1e891805e6ab6c326d565b8c0a3a7dadbac60c https://code.google.com/p/gofrontend #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	go/lex.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux

Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/gofrontend

9 years ago (2015-04-10 07:39:42 UTC) #1

iant

9 years ago (2015-04-11 00:49:44 UTC) #3

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=468b832d9163 ***

compiler: discard carriage returns in raw string literals

Fixes golang/go#10407.

LGTM=iant
R=iant
CC=gofrontend-dev
https://codereview.appspot.com/221660043

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages