Issue 22061: [issue4565] Rewrite the IO stack in C

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 22061: [issue4565] Rewrite the IO stack in C (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 11 months ago by Antoine Pitrou

Modified:
15 years, 6 months ago

Reviewers:
ajaksu

CC:
report_bugs.python.org

Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/

Visibility:
Public.

Description

The diff between the py3k and io-c branches, for whoever wants to review it.

Patch Set 1 #

Total comments: 5

Created: 15 years, 11 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+10266 lines, -2793 lines)			Patch
Doc/library/io.rst	View	2 chunks	+7 lines, -0 lines	0 comments	Download
Lib/_pyio.py	View	1 chunk	+1830 lines, -0 lines	5 comments	Download
Lib/importlib/__init__.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
Lib/importlib/_bootstrap.py	View	3 chunks	+3 lines, -3 lines	0 comments	Download
Lib/io.py	View	2 chunks	+37 lines, -2073 lines	0 comments	Download
Lib/test/test_bufio.py	View	3 chunks	+16 lines, -5 lines	0 comments	Download
Lib/test/test_descr.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
Lib/test/test_file.py	View	13 chunks	+32 lines, -15 lines	0 comments	Download
Lib/test/test_fileio.py	View	10 chunks	+37 lines, -21 lines	0 comments	Download
Lib/test/test_io.py	View	38 chunks	+1096 lines, -386 lines	0 comments	Download
Lib/test/test_largefile.py	View	8 chunks	+21 lines, -14 lines	0 comments	Download
Lib/test/test_memoryio.py	View	5 chunks	+146 lines, -29 lines	0 comments	Download
Lib/test/test_univnewlines.py	View	6 chunks	+24 lines, -12 lines	0 comments	Download
Lib/test/test_uu.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
Makefile.pre.in	View	2 chunks	+10 lines, -0 lines	0 comments	Download
Modules/Setup.dist	View	2 chunks	+3 lines, -4 lines	0 comments	Download
Modules/_bufferedio.c	View	1 chunk	+2130 lines, -0 lines	0 comments	Download
Modules/_bytesio.c	View	9 chunks	+44 lines, -46 lines	0 comments	Download
Modules/_fileio.c	View	16 chunks	+122 lines, -96 lines	0 comments	Download
Modules/_iobase.c	View	1 chunk	+902 lines, -0 lines	0 comments	Download
Modules/_iomodule.h	View	1 chunk	+150 lines, -0 lines	0 comments	Download
Modules/_stringio.c	View	11 chunks	+462 lines, -76 lines	0 comments	Download
Modules/_textio.c	View	1 chunk	+2389 lines, -0 lines	0 comments	Download
Modules/io.c	View	1 chunk	+760 lines, -0 lines	0 comments	Download
PC/VC6/pythoncore.dsp	View	4 chunks	+16 lines, -0 lines	0 comments	Download
PC/config.c	View	2 chunks	+2 lines, -6 lines	0 comments	Download
PCbuild/pythoncore.vcproj	View	4 chunks	+20 lines, -0 lines	0 comments	Download
Python/pythonrun.c	View	1 chunk	+1 line, -1 line	0 comments	Download
setup.py	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ajaksu

15 years, 11 months ago (2009-03-03 21:09:32 UTC) #2

A couple of typos in the Python implementation.

http://codereview.appspot.com/22061/diff/1/11
File Lib/_pyio.py (right):

http://codereview.appspot.com/22061/diff/1/11#newcode266
Line 266: fp is closed after the suite of the with statment is complete:
statment -> statement

http://codereview.appspot.com/22061/diff/1/11#newcode844
Line 844: self._reset_read_buf()
Setting "_read_buf" and "_read_pos" directly on __init__ may help introspection
tools.

http://codereview.appspot.com/22061/diff/1/11#newcode963
Line 963: DEAFULT_BUFFER_SIZE. If max_buffer_size is omitted, it defaults to
DEAFULT_BUFFER_SIZE -> DEFAULT_BUFFER_SIZE

http://codereview.appspot.com/22061/diff/1/11#newcode1728
Line 1728: decoder = self._decoder or self._get_decoder()
'decoder' isn't used in this method, is this here for an useful side-effect?

http://codereview.appspot.com/22061/diff/1/11#newcode1784
Line 1784: more_line = ''
This seems unused.

Expand All Messages | Collapse All Messages