Issue 2206046: Implemented functionality to collect and return info for attributes and unifo...

Issue 2206046: Implemented functionality to collect and return info for attributes and unifo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Alok Priyadarshi

Modified:
13 years, 7 months ago

Reviewers:
kbr1, dgkoch, nicolas

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Implemented functionality to collect and return info for attributes and uniforms. BUG=26

Patch Set 2 : '' #

Total comments: 8

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+293 lines, -27 lines)			Patch
M	include/GLSLANG/ShaderLang.h	View	1	1 chunk	+1 line, -0 lines	2 comments	Download
M	samples/translator/translator.cpp	View	1	8 chunks	+75 lines, -4 lines	2 comments	Download
M	src/compiler/ShaderLang.cpp	View	1	4 chunks	+49 lines, -9 lines	2 comments	Download
M	src/compiler/VariableInfo.h	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/compiler/VariableInfo.cpp	View	1	3 chunks	+162 lines, -8 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dgkoch

Nicolas: can you look this over as well? http://codereview.appspot.com/2206046/diff/3001/samples/translator/translator.cpp File samples/translator/translator.cpp (right): http://codereview.appspot.com/2206046/diff/3001/samples/translator/translator.cpp#newcode289 samples/translator/translator.cpp:289: if ...

13 years, 7 months ago (2010-09-27 13:07:10 UTC) #3

nicolas

http://codereview.appspot.com/2206046/diff/3001/include/GLSLANG/ShaderLang.h File include/GLSLANG/ShaderLang.h (right): http://codereview.appspot.com/2206046/diff/3001/include/GLSLANG/ShaderLang.h#newcode132 include/GLSLANG/ShaderLang.h:132: SH_NONE = 0, I think this should be named ...

13 years, 7 months ago (2010-09-27 14:07:59 UTC) #4

Alok Priyadarshi

13 years, 7 months ago (2010-09-27 19:25:33 UTC) #5

Thanks guys!

http://codereview.appspot.com/2206046/diff/3001/include/GLSLANG/ShaderLang.h
File include/GLSLANG/ShaderLang.h (right):

http://codereview.appspot.com/2206046/diff/3001/include/GLSLANG/ShaderLang.h#...
include/GLSLANG/ShaderLang.h:132: SH_NONE = 0,
This is modeled after GL_NONE.

http://codereview.appspot.com/2206046/diff/3001/samples/translator/translator...
File samples/translator/translator.cpp (right):

http://codereview.appspot.com/2206046/diff/3001/samples/translator/translator...
samples/translator/translator.cpp:289: if (nameSize <= 1) return;
On 2010/09/27 13:07:10, dgkoch wrote:
> is nameSize == 1 really invalid?  I guess this would only be the null
terminated
> string?

exactly - just the null termination character.

http://codereview.appspot.com/2206046/diff/3001/src/compiler/ShaderLang.cpp
File src/compiler/ShaderLang.cpp (right):

http://codereview.appspot.com/2206046/diff/3001/src/compiler/ShaderLang.cpp#n...
src/compiler/ShaderLang.cpp:51: compiler->getAttribs() :
compiler->getUniforms();
On 2010/09/27 13:07:10, dgkoch wrote:
> you might want to explicitly validate that varType can only be
> SH_ACTIVE_ATTRIBUTES or SH_ACTIVE_UNIFORMS.

Done.

http://codereview.appspot.com/2206046/diff/3001/src/compiler/VariableInfo.cpp
File src/compiler/VariableInfo.cpp (right):

http://codereview.appspot.com/2206046/diff/3001/src/compiler/VariableInfo.cpp...
src/compiler/VariableInfo.cpp:24: case 2: return SH_FLOAT_MAT2;
On 2010/09/27 13:07:10, dgkoch wrote:
> in switch statements we give the case labels a half-indent (ie 2 spaces), and
> the statements inside (if not on the same line) the other half-indent.

Done.

Expand All Messages | Collapse All Messages