Issue 2205044: Add option --disable-boost to support build without boost

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2205044: Add option --disable-boost to support build without boost (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by Peng

Modified:
14 years ago

Reviewers:
satorux

CC:
Yusuke Sato, suzhe

Base URL:
git@github.com:ibus/ibus-pinyin.git

Visibility:
Public.

Description

Add option --disable-boost to support build without boost When build without boost, ibus-pinyin will use smart pointer from c++0x and use the signal templates embedded instead of boost::signals2. BUG=chromium-os:5055 TEST=manual

Patch Set 1 #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+161 lines, -88 lines)			Patch
M	configure.ac	View	3 chunks	+16 lines, -18 lines	0 comments	Download
M	src/Makefile.am	View	2 chunks	+12 lines, -12 lines	0 comments	Download
M	src/PYBopomofoEngine.cc	View	2 chunks	+12 lines, -12 lines	0 comments	Download
M	src/PYConfig.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/PYConfig.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/PYDatabase.h	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	src/PYDatabase.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/PYEditor.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/PYEngine.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/PYExtEditor.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/PYPhraseEditor.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/PYPinyinEngine.cc	View	2 chunks	+12 lines, -12 lines	0 comments	Download
M	src/PYPunctEditor.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/PYPunctEditor.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/PYSignal.h	View	1 chunk	+73 lines, -17 lines	0 comments	Download
M	src/PYSpecialPhraseTable.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/PYUtil.h	View	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

satorux

Do we need to make it optional? Wouldn't it be simpler to get rid of ...

14 years ago (2010-09-27 05:45:39 UTC) #2

satorux

LGTM, if you believe we should support old compilers. On 2010/09/27 05:45:39, satorux wrote: > ...

14 years ago (2010-09-27 05:47:05 UTC) #3

Peng

14 years ago (2010-09-27 06:04:07 UTC) #4

On 2010/09/27 05:47:05, satorux wrote:
> LGTM, if you believe we should support old compilers.
> 
> On 2010/09/27 05:45:39, satorux wrote:
> > Do we need to make it optional? Wouldn't it be simpler to get rid of boost
> > dependencies at all? I guess we don't have to support old compilers that
don't
> > support c++0x.

Currently, I just tested it with gcc 4.4.3. I found MacOS uses 4.2. It does not
support c++-0x. And FreeBSD, Solaris may use some old version too. So I think it
is better to support the old c++ version currently. Maybe remove it in future.

Thanks for the review.

Expand All Messages | Collapse All Messages