Issue 2205043: Allow blitting to a render texture in BlitFramebuffer....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2205043: Allow blitting to a render texture in BlitFramebuffer.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by enne

Modified:
13 years, 7 months ago

Reviewers:
VangelisK, dgkoch, apatrick1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Allow blitting to a render texture in BlitFramebuffer. Change the type check to allow blitting between render buffers and render textures. Store the format for render textures so that resolving to a render texture Colorbuffer will pass the format check. BUG=37

Patch Set 1 #

Patch Set 2 : '' #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -2 lines)			Patch
M	src/libGLESv2/Context.cpp	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/libGLESv2/Renderbuffer.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/libGLESv2/Renderbuffer.cpp	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/libGLESv2/Texture.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/libGLESv2/Texture.cpp	View	1	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

enne

On 2010/09/18 03:44:16, dgkoch wrote: > LGTM Ignore this second patch set (on this bug). ...

13 years, 7 months ago (2010-09-20 22:07:57 UTC) #3

Committed in r430.

Expand All Messages | Collapse All Messages