Issue 220480043: code review 220480043: compiler: implement Go 1 unsafe.Pointer conversion rules

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 220480043: code review 220480043: compiler: implement Go 1 unsafe.Pointer conversion rules

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years ago by minux

Modified:
9 years ago

Reviewers:
iant

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

compiler: implement Go 1 unsafe.Pointer conversion rules Any type whose underlying type is uintptr can be converted to unsafe.Pointer, and vice versa. Fixes golang/go#10284.

Patch Set 1 #

Patch Set 2 : diff -r 0def388e2919207cee03cd288038ff9876089104 https://code.google.com/p/gofrontend #

Patch Set 3 : diff -r 0def388e2919207cee03cd288038ff9876089104 https://code.google.com/p/gofrontend #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	go/types.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux

Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/gofrontend

9 years ago (2015-03-30 04:25:19 UTC) #1

iant

9 years ago (2015-03-30 17:30:54 UTC) #3

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=6780bf5a7069 ***

compiler: implement Go 1 unsafe.Pointer conversion rules

Any type whose underlying type is uintptr can be converted
to unsafe.Pointer, and vice versa.

Fixes golang/go#10284.

LGTM=iant
R=iant
CC=gofrontend-dev
https://codereview.appspot.com/220480043

Committer: Ian Lance Taylor <iant@golang.org>

Expand All Messages | Collapse All Messages