Review for Python issue 5094

[brett.cannon, 2009-02-27 04:12:29]

Looks good overall with minor fixes needed, although two things are missing.
One, there are no tests for the new argument to datetime.utcnow(). Two,
PyDateTime_CAPI from datetime.h should probably grow a UTC constructor field
(along with the proper changes in datetimemodule.c).

http://codereview.appspot.com/22042/diff/1/5
File Lib/test/test_datetime.py (right):

http://codereview.appspot.com/22042/diff/1/5#newcode135
Line 135: self.assertEquals(timedelta(0), UTC().utcoffset(None))
Why the test for the None argument? Docs don't seem to suggest this is an
acceptable argument.

Same question applies to the two tests below.

http://codereview.appspot.com/22042/diff/1/6
File Modules/datetimemodule.c (right):

http://codereview.appspot.com/22042/diff/1/6#newcode3060
Line 3060: utc_init(PyObject *self)
This function is never used.

http://codereview.appspot.com/22042/diff/1/6#newcode3085
Line 3085: {"tzname",	(PyCFunction)utc_tzname,	METH_O,
Ditch the tab spacing.

http://codereview.appspot.com/22042/diff/1/6#newcode3098
Line 3098: PyDoc_STR("UTC timezone class.");
Mention it is an implementation of tzinfo.

http://codereview.appspot.com/22042/diff/1/6#newcode3947
Line 3947: if (tz_aware == Py_True)
Use PyObject_IsTrue() instead of checking for Py_True directly.

http://codereview.appspot.com/22042/diff/1/6#newcode3948
Line 3948: utc = new_utc();
Check for errors on the return value.

[ajaksu, 2009-02-27 04:38:00]

Two tiny suggestions/questions :)

http://codereview.appspot.com/22042/diff/1/4
File Doc/includes/tzinfo-examples.py (left):

http://codereview.appspot.com/22042/diff/1/4#oldcode6
Line 6: # A UTC class.
I think this bit of unused code did have some educational value... maybe it
could be added to datetime.rst?

http://codereview.appspot.com/22042/diff/1/3
File Doc/library/datetime.rst (left):

http://codereview.appspot.com/22042/diff/1/3#oldcode36
Line 36: application.  The rules for time adjustment across the world are more
political
Maybe a (footnote) mention of/ link to pytz could add value for users reading
this doc?