DispatchAsync without GWT-RPC (issue 2171043) - Update

This is an update of issue 2171043 : 
* use gwtp-0.4 instead of gwtp-0.3
* use JSON to communicate with the server
* use piriti as a parsing lib (for JSON/XML)

[Damob, 2010-09-15 12:15:39]

My review is incomplete, I'll take another look tonight.

Great work btw !

http://codereview.appspot.com/2202041/diff/1/dispatch-without-gwtrpc/src/com/...
File
dispatch-without-gwtrpc/src/com/gwtplatform/samples/dispatchwithoutgwtrpc/client/MainPagePresenter.java
(right):

http://codereview.appspot.com/2202041/diff/1/dispatch-without-gwtrpc/src/com/...
dispatch-without-gwtrpc/src/com/gwtplatform/samples/dispatchwithoutgwtrpc/client/MainPagePresenter.java:45:
PresenterImpl<MainPagePresenter.MyView, MainPagePresenter.MyProxy> {
Please use Gwt convention (two spaces, no tabs)

see:
http://code.google.com/p/gwt-platform/wiki/ContributorGuidelines

In Gwtp 0.4, presenterImpl has been deprecated. User presenter instead.

http://codereview.appspot.com/2202041/diff/1/dispatch-without-gwtrpc/src/com/...
dispatch-without-gwtrpc/src/com/gwtplatform/samples/dispatchwithoutgwtrpc/client/MainPagePresenter.java:62:

I agree with marius here, try to use @UiHandler with UiHandlers:
http://code.google.com/p/gwt-platform/wiki/GettingStarted#Delegate_some_actio...

http://codereview.appspot.com/2202041/diff/1/dispatch-without-gwtrpc/src/com/...
dispatch-without-gwtrpc/src/com/gwtplatform/samples/dispatchwithoutgwtrpc/client/MainPagePresenter.java:103:
public interface MyProxy extends Proxy<MainPagePresenter>, Place {
There's a composite that exist for that: ProxyPlace

http://codereview.appspot.com/2202041/diff/1/dispatch-without-gwtrpc/src/com/...
File
dispatch-without-gwtrpc/src/com/gwtplatform/samples/dispatchwithoutgwtrpc/client/dispatch/DispatchAsyncRequestBuilderImpl.java
(right):

http://codereview.appspot.com/2202041/diff/1/dispatch-without-gwtrpc/src/com/...
dispatch-without-gwtrpc/src/com/gwtplatform/samples/dispatchwithoutgwtrpc/client/dispatch/DispatchAsyncRequestBuilderImpl.java:92:
return new DispatchRequestRequestBuilderImpl(requestBuilder.send());
There's alreay a static factory: DispatchRequestFactory.createRequest() and
Request is already implemented.

http://codereview.appspot.com/2202041/diff/1/dispatch-without-gwtrpc/src/com/...
File
dispatch-without-gwtrpc/src/com/gwtplatform/samples/dispatchwithoutgwtrpc/server/ItemsManagerServlet.java
(right):

http://codereview.appspot.com/2202041/diff/1/dispatch-without-gwtrpc/src/com/...
dispatch-without-gwtrpc/src/com/gwtplatform/samples/dispatchwithoutgwtrpc/server/ItemsManagerServlet.java:30:

Just a though:
Since we use the same server as the client side... why don't we try to use
common Action Handler ?
HttpServletRequest and response are injectable with guice.