Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(61)

Issue 2200045: Add the right include for ASCIITo* functions.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by tfarina1
Modified:
14 years, 10 months ago
CC:
rlz-codereviews_googlegroups.com, brettw
Base URL:
http://rlz.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add the right include for ASCIITo* functions. It should include base/utf_string_conversions.h to get the definition of those functions, instead of including base/string_utils.h, because theses definitions are subject to be removed from string_utils.h soon (since they already been moved to utf_string_conversions.h). BUG=None TEST=compiles Patch from Thiago Farina <tfarina@chromium.org> Committed: http://code.google.com/p/rlz/source/detail?r=23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M win/lib/rlz_lib.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M win/lib/string_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
tfarina1
Hi Roger, this is a fix for the hack in: http://codereview.chromium.org/3255002/diff/1/2 Please, could you review ...
14 years, 10 months ago (2010-09-20 21:22:15 UTC) #1
Roger Tawa (Google)
lgtm Thanks Thiago. I will commit shortly.
14 years, 10 months ago (2010-09-21 13:47:07 UTC) #2
Roger Tawa (Google)
Hi Thiago, I submitted your change as revision 23. Thanks, Roger - On Tue, Sep ...
14 years, 10 months ago (2010-09-21 14:53:06 UTC) #3
tfarina1
On 2010/09/21 14:53:06, rogerta wrote: > Hi Thiago, > > I submitted your change as ...
14 years, 10 months ago (2010-09-21 18:59:08 UTC) #4
Roger Tawa (Google)
14 years, 10 months ago (2010-09-21 20:01:13 UTC) #5
Hi Thiago,

You have a good point.  I assumed that the code review would remain
available, but maybe not a good assumption.  I'll do as you suggest.

Thanks,
Roger

-


On Tue, Sep 21, 2010 at 14:59, <tfarina@chromium.org> wrote:

> On 2010/09/21 14:53:06, rogerta wrote:
>
>> Hi Thiago,
>>
>
>  I submitted your change as revision 23.
>>
>
> Thanks Roger.
>
> I think would be good if you keep the original description when
> committing, because it helps someone reading the log to see what changed
> without needing to go to codereview. Also, codereview may be not
> available forever (how will knows).
>
>
> http://codereview.appspot.com/2200045/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b