Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(17390)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 219860043: Changes for issue #48. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by Joachim Metz
Modified:
9 years, 1 month ago
Reviewers:
kiddi, onager
CC:
log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

These files are missing unit tests: + plaso/events/shell_item_events.py + plaso/formatters/shell_items.py + plaso/parsers/shared/shell_items.py

Patch Set 1 #

Total comments: 6

Patch Set 2 : Submitted. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -104 lines) Patch
M config/dpkg/changelog View 1 1 chunk +1 line, -1 line 0 comments Download
M plaso/engine/worker.py View 4 chunks +20 lines, -5 lines 0 comments Download
M plaso/events/shell_item_events.py View 3 chunks +3 lines, -1 line 0 comments Download
M plaso/formatters/shell_items.py View 2 chunks +29 lines, -1 line 0 comments Download
M plaso/formatters/winlnk.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/custom_destinations_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/parsers/olecf_plugins/automatic_destinations_test.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/shared/shell_items.py View 1 7 chunks +89 lines, -29 lines 0 comments Download
M plaso/parsers/winlnk.py View 1 chunk +3 lines, -7 lines 0 comments Download
M plaso/parsers/winlnk_test.py View 7 chunks +10 lines, -8 lines 0 comments Download
M plaso/parsers/winreg_plugins/bagmru.py View 8 chunks +24 lines, -17 lines 0 comments Download
M plaso/parsers/winreg_plugins/bagmru_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/parsers/winreg_plugins/mrulist.py View 1 chunk +2 lines, -2 lines 0 comments Download
M plaso/parsers/winreg_plugins/mrulist_test.py View 2 chunks +3 lines, -2 lines 0 comments Download
M plaso/parsers/winreg_plugins/mrulistex.py View 3 chunks +6 lines, -7 lines 0 comments Download
M plaso/parsers/winreg_plugins/mrulistex_test.py View 3 chunks +20 lines, -18 lines 0 comments Download

Messages

Total messages: 4
Joachim Metz
9 years, 1 month ago (2015-03-17 11:13:51 UTC) #1
kiddi
LGTM, only minor nitpicks https://codereview.appspot.com/219860043/diff/1/plaso/parsers/shared/shell_items.py File plaso/parsers/shared/shell_items.py (right): https://codereview.appspot.com/219860043/diff/1/plaso/parsers/shared/shell_items.py#newcode145 plaso/parsers/shared/shell_items.py:145: # Remove a trailing \ ...
9 years, 1 month ago (2015-03-17 23:18:53 UTC) #2
Joachim Metz
https://codereview.appspot.com/219860043/diff/1/plaso/parsers/shared/shell_items.py File plaso/parsers/shared/shell_items.py (right): https://codereview.appspot.com/219860043/diff/1/plaso/parsers/shared/shell_items.py#newcode145 plaso/parsers/shared/shell_items.py:145: # Remove a trailing \ except for the ast ...
9 years, 1 month ago (2015-03-18 06:40:30 UTC) #3
Joachim Metz
9 years, 1 month ago (2015-03-18 06:41:45 UTC) #4 
Code Submitted.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b