Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 219780043: Don't create Bottom to announce TimeSignatureEvent (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 1 month ago by dak
Modified:
8 years, 10 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Don't create Bottom to announce TimeSignatureEvent As a fallout of issue 4138, << \time 3/4 \new Staff c2. >> created a spurious Staff only containing a time signature. This change avoids the creation of a Bottom context just for accommodating \time. As a result, { \tweak color #red \time 3/4 c2. } will no longer show a change in color since no Staff context exists at the time \time is executed and consequently the tweak does not apply anywhere. You have to use \time in existing Staff contexts to have either \tweak and point&click have an effect (and get an error locator when something with typesetting the signature goes wrong). Outside of such contexts, \time just changes properties of the Timing context.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M scm/define-music-callbacks.scm View 1 chunk +18 lines, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b