Issue 2194043: Allow multisampling without enabling GL_SAMPLE_COVERAGE....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2194043: Allow multisampling without enabling GL_SAMPLE_COVERAGE.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by enne

Modified:
13 years, 7 months ago

Reviewers:
VangelisK, dgkoch, apatrick1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Allow multisampling without enabling GL_SAMPLE_COVERAGE. This setting is only used when an application wants to control which samples are written to. If it is disabled, multisampling should just write to all samples. BUG=38

Patch Set 1 #

Patch Set 2 : '' #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -20 lines)			Patch
	M	src/libGLESv2/Context.cpp	View	1	1 chunk	+27 lines, -20 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

enne

On 2010/09/18 03:46:09, dgkoch wrote: > Good catch. > > LGTM One more quick thing. ...

13 years, 7 months ago (2010-09-20 17:49:46 UTC) #3

enne

13 years, 7 months ago (2010-09-21 16:43:09 UTC) #5

On 2010/09/21 15:06:40, dgkoch wrote:
> LGTM

Committed in r431.

Expand All Messages | Collapse All Messages