Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3645)

Issue 2191042: Tablature: proper support for tie/slur- and tie/glissando-constellations (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by marc
Modified:
13 years, 3 months ago
Reviewers:
valentin, carl.d.sorensen, Neil Puttock, c_sorensen, Trevor Daniels, Graham Percival
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Tablature: proper support for tie/slur- and tie/glissando-constellations If a tie is followed by a slur or a glissando, the (normally invisible) fret number has to be displayed in parentheses. In case of a following glissando, the left starting point is corrected so it doesn't interfere with the closing parenthesis. To provide a proper "signal" for these situations, the TabNoteHead #'details were expanded by 'tied-to, which is set to #t by the tablature tie handling routine.

Patch Set 1 #

Total comments: 11

Patch Set 2 : First set of corrections #

Patch Set 3 : New approach with engraver #

Patch Set 4 : Removed the declaration of 'tie-follow in scm/define-grobs.scm, since it is an internal property #

Total comments: 1

Patch Set 5 : changing version number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -52 lines) Patch
A input/regression/tablature-tie-slur-glissando.ly View 1 2 3 4 1 chunk +27 lines, -0 lines 0 comments Download
M ly/engraver-init.ly View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ly/property-init.ly View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-grob-interfaces.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/define-grob-properties.scm View 2 1 chunk +3 lines, -0 lines 0 comments Download
M scm/tablature.scm View 1 2 1 chunk +162 lines, -51 lines 0 comments Download

Messages

Total messages: 19
Carl
Looks good to me. Just a comment on the name of the new property to ...
13 years, 6 months ago (2010-09-16 10:32:52 UTC) #1
marc
Carl.D.Sorensen@gmail.com schrieb: > Looks good to me. Just a comment on the name of the ...
13 years, 6 months ago (2010-09-16 12:15:47 UTC) #2
Neil Puttock
Hi Marc, In hide-tab-note-head, you end up setting properties on bounds which aren't noteheads (i.e., ...
13 years, 6 months ago (2010-09-16 21:14:18 UTC) #3
marc
n.puttock@gmail.com schrieb: > Hi Marc, Hello Neil, > > In hide-tab-note-head, you end up setting ...
13 years, 6 months ago (2010-09-17 07:01:40 UTC) #4
Neil Puttock
On 2010/09/17 07:01:40, marc wrote: > TO be honest, I don't understand what you mean ...
13 years, 6 months ago (2010-09-18 20:21:12 UTC) #5
Graham Percival
On Sat, Sep 18, 2010 at 9:21 PM, <n.puttock@gmail.com> wrote: > On 2010/09/17 07:01:40, marc ...
13 years, 6 months ago (2010-09-18 20:25:34 UTC) #6
marc
n.puttock@gmail.com schrieb: > On 2010/09/17 07:01:40, marc wrote: > >> TO be honest, I don't ...
13 years, 6 months ago (2010-09-19 09:06:13 UTC) #7
marc
Am 18.09.2010 22:21, schrieb n.puttock@gmail.com: > [...] > I think the only sane method would ...
13 years, 5 months ago (2010-10-20 09:12:32 UTC) #8
marc
Am 20.10.2010 11:12, schrieb Marc Hohl: > Am 18.09.2010 22:21, schrieb n.puttock@gmail.com: >> [...] >> ...
13 years, 5 months ago (2010-10-27 09:00:17 UTC) #9
valentin_villenave.net
On Wed, Oct 27, 2010 at 11:00 AM, Marc Hohl <marc@hohlart.de> wrote: > I know, ...
13 years, 5 months ago (2010-10-27 10:14:11 UTC) #10
Graham Percival
On Wed, Oct 27, 2010 at 11:14 AM, Valentin Villenave <valentin@villenave.net> wrote: > On Wed, ...
13 years, 5 months ago (2010-10-27 11:30:59 UTC) #11
marc
Am 27.10.2010 12:14, schrieb Valentin Villenave: > On Wed, Oct 27, 2010 at 11:00 AM, ...
13 years, 5 months ago (2010-10-27 18:30:36 UTC) #12
Carl
LGTM. However, I'm a bit nervous about putting bends as well into the Tab_tie_follow_engraver. Not ...
13 years, 5 months ago (2010-10-28 12:53:01 UTC) #13
Trevor Daniels
I've not reviewed the code but I share Carl's concern about scheme engravers if there ...
13 years, 5 months ago (2010-10-28 18:34:41 UTC) #14
marc
Am 28.10.2010 20:34, schrieb tdanielsmusic@googlemail.com: > I've not reviewed the code but I share Carl's ...
13 years, 5 months ago (2010-10-28 19:48:24 UTC) #15
marc
Am 28.10.2010 14:53, schrieb Carl.D.Sorensen@gmail.com: > LGTM. > > However, I'm a bit nervous about ...
13 years, 5 months ago (2010-10-28 19:54:26 UTC) #16
c_sorensen
On 10/28/10 1:54 PM, "Marc Hohl" <marc@hohlart.de> wrote: > Am 28.10.2010 14:53, schrieb Carl.D.Sorensen@gmail.com: >> ...
13 years, 5 months ago (2010-10-28 22:15:48 UTC) #17
marc
Am 28.10.2010 14:53, schrieb Carl.D.Sorensen@gmail.com: > LGTM. > > However, I'm a bit nervous about ...
13 years, 5 months ago (2010-10-29 09:03:46 UTC) #18
Carl
13 years, 5 months ago (2010-10-31 03:33:46 UTC) #19
I've put a new patch up on Rietveld, with the Scheme engraver moved to a C++
engraver to avoid the challenges with documentation.

http://codereview.appspot.com/2723043

Thanks,

Carl
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b