Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1397)

Issue 21820045: Fill in section "\set vs \override" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by dak
Modified:
10 years, 2 months ago
Reviewers:
Keith, benrg, Trevor Daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fill in section "\set vs \override"

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -13 lines) Patch
M Documentation/notation/changing-defaults.itely View 1 chunk +53 lines, -13 lines 0 comments Download

Messages

Total messages: 4
Trevor Daniels
LGTM. I think it's OK at the end of this section as a sort of ...
10 years, 6 months ago (2013-11-06 13:41:54 UTC) #1
benrg
As someone who barely understands LilyPond's internals I appreciate this explanation, but it still leaves ...
10 years, 6 months ago (2013-11-07 00:04:43 UTC) #2
Keith
On 2013/11/07 00:04:43, benrg wrote: > I don't see why tempoHideNote should be a context ...
10 years, 6 months ago (2013-11-07 07:25:09 UTC) #3
dak
10 years, 5 months ago (2013-11-10 09:46:27 UTC) #4
On 2013/11/07 00:04:43, benrg wrote:
> As someone who barely understands LilyPond's internals I appreciate this
> explanation, but it still leaves me confused. It seems to be saying that grob
> properties are an additional hierarchical override system below the level of
> context properties, but I don't see why that's needed when context properties
> already behave in a similar way.

Not similar enough.  Grob definitions implement a stack in several respects.

> Also, the assignment of properties to the
> context or grob "genders" seems somewhat arbitrary; I don't see why
> tempoHideNote should be a context property and BarNumber.break-visibility a
grob
> property, for example.

So what?  If you find something that logically is tied to grob to be implemented
as a plain context property or the other way round, feel free to report this.

This section can't possibly explain the raison d'ĂȘtre for every single property.

> Especially now that there is a unified dot syntax, could \set and \override be
> made synonyms that work out internally what kind of property to set, making
the
> distinction an internal detail that most people could ignore?

No.  Internals of grob definitions are sufficiently different that this is not
feasible without a major redesign of the data structures.  And while it is
popular to shout "then do a major redesign" and they actually do happen, they
take years and more shouting will not change that.

> (This is a clarification request, not a feature request. I find it helpful if
> documentation mentions which features of a design are historical accidents
that
> wouldn't exist if everything were reimplemented from scratch.)

They are most certainly not a "historical accident".  They were closer at some
point of time, but performance was prohibitive, so they quite intentionally
diverged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b