Load cajita-debugmode.js if debug=1

This change introduces the feature caja-debug which is loaded by CajaContentRewriter if debug mode is enabled.

Make CajaContentRewriter#cajaEnabled protected since subclasses may have different requirements for enabling/disabling caja.

[chirag, 2010-09-10 19:07:57]

adding dev-remailer@shindig.apache.org

[Jasvir, 2010-09-10 20:02:02]

http://codereview.appspot.com/2175042/diff/1/java/gadgets/src/main/java/org/a...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
(right):

http://codereview.appspot.com/2175042/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:130:
gadget.addFeature("caja-debug");
Ok in this case a developer should never themselves Require "caja-debug" since
that would either give an error (if they're not also requiring "caja") or
doesn't stop the minify.

http://codereview.appspot.com/2175042/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:203:
protected boolean cajaEnabled(Gadget gadget) {
Why?

[chirag, 2010-09-10 21:01:35]

http://codereview.appspot.com/2175042/diff/1/java/gadgets/src/main/java/org/a...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
(right):

http://codereview.appspot.com/2175042/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:130:
gadget.addFeature("caja-debug");
In that case, the caja feature will get pulled in as a transitive dependency.
caja-debug depends on caja.

On 2010/09/10 20:02:02, jasvir wrote:
> Ok in this case a developer should never themselves Require "caja-debug" since
> that would either give an error (if they're not also requiring "caja") or
> doesn't stop the minify.

http://codereview.appspot.com/2175042/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:203:
protected boolean cajaEnabled(Gadget gadget) {
Different containers may have different requirements for enabling/disabling
caja. For instance, a container may want to enable caja depending on the
capabilities of the gadget being rendered.

Another example would be turning caja on at a container specific level. (Pass
container=cajacontainer and add a caja directive inside the cajacontainer.js)
https://svn.apache.org/repos/asf/shindig/trunk/config/container.js

I'm also in the process of writing unit tests for CajaContentRewriter, and
wanted to create an individual test for this method.

On 2010/09/10 20:02:02, jasvir wrote:
> Why?

[Jasvir, 2010-09-10 21:12:39]

http://codereview.appspot.com/2175042/diff/1/java/gadgets/src/main/java/org/a...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
(right):

http://codereview.appspot.com/2175042/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:130:
gadget.addFeature("caja-debug");
Cool.  I don't see where that dependency is created.  caja-debug/feature.xml
doesn't show up properly in codereview but the diff didn't show me anything that
looked like a dependency.

On 2010/09/10 21:01:35, chirag wrote:
> In that case, the caja feature will get pulled in as a transitive dependency.
> caja-debug depends on caja.
> 
> On 2010/09/10 20:02:02, jasvir wrote:
> > Ok in this case a developer should never themselves Require "caja-debug"
since
> > that would either give an error (if they're not also requiring "caja") or
> > doesn't stop the minify.
> 
>

http://codereview.appspot.com/2175042/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:203:
protected boolean cajaEnabled(Gadget gadget) {
Makes sense.

On 2010/09/10 21:01:35, chirag wrote:
> Different containers may have different requirements for enabling/disabling
> caja. For instance, a container may want to enable caja depending on the
> capabilities of the gadget being rendered.
> 
> Another example would be turning caja on at a container specific level. (Pass
> container=cajacontainer and add a caja directive inside the cajacontainer.js)
> https://svn.apache.org/repos/asf/shindig/trunk/config/container.js
> 
> I'm also in the process of writing unit tests for CajaContentRewriter, and
> wanted to create an individual test for this method.
> 
> On 2010/09/10 20:02:02, jasvir wrote:
> > Why?
> 
>

[chirag, 2010-09-10 21:24:50]

Fix caja-debug/feature.xml

[chirag, 2010-09-10 21:26:31]

http://codereview.appspot.com/2175042/diff/1/java/gadgets/src/main/java/org/a...
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java
(right):

http://codereview.appspot.com/2175042/diff/1/java/gadgets/src/main/java/org/a...
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java:130:
gadget.addFeature("caja-debug");
Good catch!  I just posted another patch set with the dependency.

On 2010/09/10 21:12:39, jasvir wrote:
> Cool.  I don't see where that dependency is created.  caja-debug/feature.xml
> doesn't show up properly in codereview but the diff didn't show me anything
that
> looked like a dependency.
> 
> On 2010/09/10 21:01:35, chirag wrote:
> > In that case, the caja feature will get pulled in as a transitive
dependency.
> > caja-debug depends on caja.
> > 
> > On 2010/09/10 20:02:02, jasvir wrote:
> > > Ok in this case a developer should never themselves Require "caja-debug"
> since
> > > that would either give an error (if they're not also requiring "caja") or
> > > doesn't stop the minify.
> > 
> > 
> 
>

[Paul Lindner, 2010-09-10 22:45:14]

lgtm