Add additional error checking to capsule in _ctypes/callproc.c

[Benjamin, 2010-02-23 04:26:11]

http://codereview.appspot.com/217092/diff/1/2
File Modules/_ctypes/callproc.c (right):

http://codereview.appspot.com/217092/diff/1/2#newcode144
Modules/_ctypes/callproc.c:144: Py_DECREF(errobj);
Don't decref. PyDict_GetItem returns a borrowed reference.

Does PyCapsule_IsValid set an error? If not just retuning NULL will not work.

[Benjamin, 2010-02-24 01:47:30]

Only a few style issues now.

http://codereview.appspot.com/217092/diff/7/1002
File Modules/_ctypes/callproc.c (right):

http://codereview.appspot.com/217092/diff/7/1002#newcode145
Modules/_ctypes/callproc.c:145: "ctypes.error_object is an invalid capsule");
Looks like this needs to be wrapped.

http://codereview.appspot.com/217092/diff/7/1002#newcode149
Modules/_ctypes/callproc.c:149: } else {
Style at the moment dictates that the } and else be on separate lines.

[Larry Hastings, 2010-02-24 03:00:54]

Ran the unit tests one last time, and those ran fine.  Little surprise there
really.

Thanks,


/larry/

http://codereview.appspot.com/217092/diff/7/1002
File Modules/_ctypes/callproc.c (right):

http://codereview.appspot.com/217092/diff/7/1002#newcode145
Modules/_ctypes/callproc.c:145: "ctypes.error_object is an invalid capsule");
It was a spaces-mixed-with-tabs issue.  My editor was aggressively de-tabbing. 
ctypes is all tabs, so this is now tabs too, now lines up correctly with
shiftwidth 4.
On 2010/02/24 01:47:30, Benjamin wrote:
> Looks like this needs to be wrapped.

http://codereview.appspot.com/217092/diff/7/1002#newcode149
Modules/_ctypes/callproc.c:149: } else {
Done.
On 2010/02/24 01:47:30, Benjamin wrote:
> Style at the moment dictates that the } and else be on separate lines.

[Benjamin, 2010-02-24 03:05:54]

LGTM