Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1234)

Issue 2166043: Add codereview.settings. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by satorux
Modified:
13 years, 7 months ago
Reviewers:
Peng Huang
CC:
Yusuke Sato
Base URL:
git://github.com/phuang/ibus.git
Visibility:
Public.

Description

Add codereview.settings. This is for us to use codereview.appspot.com for code reviews. Instructions to use codereview.appspot.com: 1. Get depot_tools and add PATH to the directory http://dev.chromium.org/developers/how-tos/depottools 2. In your local IBus git repository, % git checkout master % git checkout -b somefix make changes % git cl upload do code reviews at codereview.appspot.com once it's done, run "git cl push" if you can commit. otherwise, ask committers to commit on behalf.

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
A codereview.settings View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2
satorux
13 years, 7 months ago (2010-09-08 01:47:12 UTC) #1
Peng Huang
13 years, 7 months ago (2010-09-08 06:05:20 UTC) #2
On 2010/09/08 01:47:12, satorux wrote:
> 

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b