Issue 2161043: code review 2161043: test: Reduce race conditions in chan/nonblock.go.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2161043: code review 2161043: test: Reduce race conditions in chan/nonblock.go. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by iant

Modified:
14 years, 8 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

test: Reduce race conditions in chan/nonblock.go. nonblock.go wants to test nonblocking operations on synchronous channels, so it is inherently racy. This introduces loops to make the race conditions much more likely to succeed when using gccgo.

Patch Set 1 #

Patch Set 2 : code review 2161043: test: Reduce race conditions in chan/nonblock.go. #

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -38 lines)			Patch
	M	test/chan/nonblock.go	View	1	5 chunks	+60 lines, -38 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 8 months ago (2010-09-10 22:03:17 UTC) #1

iant

14 years, 8 months ago (2010-09-10 22:37:30 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=cb7bc94a378a ***

test: Reduce race conditions in chan/nonblock.go.

nonblock.go wants to test nonblocking operations on
synchronous channels, so it is inherently racy.  This
introduces loops to make the race conditions much more likely
to succeed when using gccgo.

R=r
CC=golang-dev
http://codereview.appspot.com/2161043

Expand All Messages | Collapse All Messages