Issue 2154045: Backing out r417 and r418....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2154045: Backing out r417 and r418....

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by apatrick1

Modified:
13 years, 8 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Backing out r417 and r418. I will recommit these as two separate patches: one for ID invalidation and one for reference counting issue. I will not recommit the FBO changes and since the GLES2 spec will soon make it undefined whether FBOs are in a shared namespace.

Patch Set 1 #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+118 lines, -181 lines)			Patch
M	src/libGLESv2/Context.h	View	3 chunks	+11 lines, -7 lines	0 comments	Download
M	src/libGLESv2/Context.cpp	View	19 chunks	+81 lines, -57 lines	0 comments	Download
M	src/libGLESv2/Framebuffer.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/libGLESv2/Framebuffer.cpp	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/libGLESv2/RefCountObject.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/libGLESv2/RefCountObject.cpp	View	3 chunks	+0 lines, -19 lines	0 comments	Download
M	src/libGLESv2/ResourceManager.h	View	3 chunks	+1 line, -9 lines	0 comments	Download
M	src/libGLESv2/ResourceManager.cpp	View	6 chunks	+3 lines, -70 lines	0 comments	Download
M	src/libGLESv2/Texture.h	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	src/libGLESv2/Texture.cpp	View	4 chunks	+16 lines, -8 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

apatrick1

Hi Daniel, Just backing these out in preparation for submitting new better organized patches. Al

13 years, 8 months ago (2010-09-13 21:41:16 UTC) #1

Approved.

Expand All Messages | Collapse All Messages