Issue 2146042: S32A_Blend_BlitRow32 - Optimise for ARM Cores lacking NEON

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2146042: S32A_Blend_BlitRow32 - Optimise for ARM Cores lacking NEON (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Vassilis

Modified:
13 years, 7 months ago

Reviewers:
Antoine Labour, Stephen White, agl

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

The S32A_Blend_BlitRow32 function was written and unrolled in ARM assembly to improve the rendering performance on ARM cores lacking NEON. Added in SkBlitRow_opts_arm.cpp Performance improvement about ~18% on micro benchmarking.

Patch Set 1 #

Patch Set 2 : Previous patch - some comments improvement :o) #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -1 line)			Patch
		src/opts/SkBlitRow_opts_arm.cpp	View	1	2 chunks	+136 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Antoine Labour

LGTM. I looked at the assembly code and it looks sane to me. I'll need ...

13 years, 7 months ago (2010-09-08 22:43:38 UTC) #3

agl

Will review tomorrow. On Sep 8, 2010 6:43 PM, <piman@google.com> wrote: > LGTM. I looked ...

13 years, 7 months ago (2010-09-09 01:01:32 UTC) #4

Vassilis

13 years, 7 months ago (2010-09-13 13:30:26 UTC) #6

On 2010/09/10 15:10:07, agl wrote:
> landed in r598

Thanks guys! :)
Closing this down.

Expand All Messages | Collapse All Messages