New module account_stock_continental

[timitos, 2010-09-15 16:41:25]

http://codereview.appspot.com/2142048/diff/2001/doc/index.rst
File doc/index.rst (right):

http://codereview.appspot.com/2142048/diff/2001/doc/index.rst#newcode9
doc/index.rst:9: - Account Stock: The account which is used to record stock
value.
account must be part of balance sheet

http://codereview.appspot.com/2142048/diff/2001/doc/index.rst#newcode11
doc/index.rst:11: - Account Stock Output: The counter part account for output
stock.
input and output account must be part of income sheet

http://codereview.appspot.com/2142048/diff/2001/doc/index.rst#newcode22
doc/index.rst:22: Location has the type "Storage".
What about Stock Location of type "production"? I think it is a subtype of
"Storage". So it should be handled like this.

http://codereview.appspot.com/2142048/diff/2001/doc/index.rst#newcode25
doc/index.rst:25: Stock of the Product is credited and the Account Stock Input
of the Product is
Stock of the Produkt is DEBITED

http://codereview.appspot.com/2142048/diff/2001/doc/index.rst#newcode26
doc/index.rst:26: debited. The amount is the Unit Price of the move if the
origin is a "Supplier"
CREDITED.

http://codereview.appspot.com/2142048/diff/2001/doc/index.rst#newcode30
doc/index.rst:30: the Product is debited and the Account Stock Ouput of the
Product is debited.
the Product is credited and the Account Stock Ouput of the Product is debited.

[ced, 2010-09-15 16:58:26]

http://codereview.appspot.com/2142048/diff/2001/doc/index.rst
File doc/index.rst (right):

http://codereview.appspot.com/2142048/diff/2001/doc/index.rst#newcode9
doc/index.rst:9: - Account Stock: The account which is used to record stock
value.
On 2010/09/15 16:41:25, timitos wrote:
> account must be part of balance sheet

We don't make any constraint of this kind in Tryton.

http://codereview.appspot.com/2142048/diff/2001/doc/index.rst#newcode22
doc/index.rst:22: Location has the type "Storage".
On 2010/09/15 16:41:25, timitos wrote:
> What about Stock Location of type "production"? I think it is a subtype of
> "Storage". So it should be handled like this.

The production location is not a storage so there will be account move.

[timitos, 2010-09-15 17:02:01]

ok

[timitos, 2010-09-15 17:24:34]

On 2010/09/15 16:58:26, ced wrote:
> http://codereview.appspot.com/2142048/diff/2001/doc/index.rst
> File doc/index.rst (right):
> 
> http://codereview.appspot.com/2142048/diff/2001/doc/index.rst#newcode9
> doc/index.rst:9: - Account Stock: The account which is used to record stock
> value.
> On 2010/09/15 16:41:25, timitos wrote:
> > account must be part of balance sheet
> 
> We don't make any constraint of this kind in Tryton.
> 
> http://codereview.appspot.com/2142048/diff/2001/doc/index.rst#newcode22
> doc/index.rst:22: Location has the type "Storage".
> On 2010/09/15 16:41:25, timitos wrote:
> > What about Stock Location of type "production"? I think it is a subtype of
> > "Storage". So it should be handled like this.
> 
> The production location is not a storage so there will be account move.
I thought again about this. You are right.

[yangoon1, 2010-12-05 20:14:06]

http://codereview.appspot.com/2142048/diff/64001/INSTALL
File INSTALL (right):

http://codereview.appspot.com/2142048/diff/64001/INSTALL#newcode9
INSTALL:9: * trytond_account (http://www.tryton.org/)
* trytond_account_product (http://www.tryton.org/)
is missing, but direct dependency

http://codereview.appspot.com/2142048/diff/64001/__init__.py
File __init__.py (right):

http://codereview.appspot.com/2142048/diff/64001/__init__.py#newcode2
__init__.py:2: #this repository contains the full copyright notices and license
terms.
missing empty line

http://codereview.appspot.com/2142048/diff/64001/setup.py
File setup.py (right):

http://codereview.appspot.com/2142048/diff/64001/setup.py#newcode33
setup.py:33: 'trytond.modules.account.tests',
'trytond.modules.account_stock_continental.tests'

http://codereview.appspot.com/2142048/diff/64001/stock.py
File stock.py (right):

http://codereview.appspot.com/2142048/diff/64001/stock.py#newcode81
stock.py:81: # Input
comment is more useful before if, here it is rather self-explaining with the
following line

http://codereview.appspot.com/2142048/diff/64001/tests/scenario_account_stock...
File tests/scenario_account_stock_continental.rst (right):

http://codereview.appspot.com/2142048/diff/64001/tests/scenario_account_stock...
tests/scenario_account_stock_continental.rst:9: Imports::
Somewhere should be documented how to run this test (trytond and proteus in
PYTHONPATH, where to get proteus)

[ced, 2010-12-05 20:51:45]

http://codereview.appspot.com/2142048/diff/64001/stock.py
File stock.py (right):

http://codereview.appspot.com/2142048/diff/64001/stock.py#newcode81
stock.py:81: # Input
On 2010/12/05 20:14:06, yangoon wrote:
> comment is more useful before if, here it is rather self-explaining with the
> following line

I don't find because you don't know to which part the comment is linked.

http://codereview.appspot.com/2142048/diff/64001/tests/scenario_account_stock...
File tests/scenario_account_stock_continental.rst (right):

http://codereview.appspot.com/2142048/diff/64001/tests/scenario_account_stock...
tests/scenario_account_stock_continental.rst:9: Imports::
On 2010/12/05 20:14:06, yangoon wrote:
> Somewhere should be documented how to run this test (trytond and proteus in
> PYTHONPATH, where to get proteus)
It is run like any others

[yangoon1, 2010-12-05 21:35:02]

http://codereview.appspot.com/2142048/diff/64001/tests/scenario_account_stock...
File tests/scenario_account_stock_continental.rst (right):

http://codereview.appspot.com/2142048/diff/64001/tests/scenario_account_stock...
tests/scenario_account_stock_continental.rst:9: Imports::
On 2010/12/05 20:51:45, ced wrote:
> On 2010/12/05 20:14:06, yangoon wrote:
> > Somewhere should be documented how to run this test (trytond and proteus in
> > PYTHONPATH, where to get proteus)
> It is run like any others

It needs proteus, which is not included in trytond.

[yangoon1, 2010-12-05 22:02:23]

Testing on an updated database shows strange behavior for switch view on
products. Instead of back switching from form to tree view it jumps to Tab
Accounting.

Anyone else? /me otherwise throwing this database...

[ced, 2010-12-05 22:12:03]

http://codereview.appspot.com/2142048/diff/64001/tests/scenario_account_stock...
File tests/scenario_account_stock_continental.rst (right):

http://codereview.appspot.com/2142048/diff/64001/tests/scenario_account_stock...
tests/scenario_account_stock_continental.rst:9: Imports::
On 2010/12/05 21:35:03, yangoon wrote:
> On 2010/12/05 20:51:45, ced wrote:
> > On 2010/12/05 20:14:06, yangoon wrote:
> > > Somewhere should be documented how to run this test (trytond and proteus
in
> > > PYTHONPATH, where to get proteus)
> > It is run like any others
> 
> It needs proteus, which is not included in trytond.

I did not find how in setup.py define dependencies for test

[ced, 2010-12-05 22:12:26]

On 2010/12/05 22:02:23, yangoon wrote:
> Testing on an updated database shows strange behavior for switch view on
> products. Instead of back switching from form to tree view it jumps to Tab
> Accounting.
> 
> Anyone else? /me otherwise throwing this database...

I guess you must define some stock accounts

[yangoon1, 2010-12-06 18:26:18]

On 2010/12/05 22:12:26, ced wrote:
> On 2010/12/05 22:02:23, yangoon wrote:
> > Testing on an updated database shows strange behavior for switch view on
> > products. Instead of back switching from form to tree view it jumps to Tab
> > Accounting.
> > 
> > Anyone else? /me otherwise throwing this database...
> 
> I guess you must define some stock accounts

Indeed. I tapped in the trap. With only account_product installed
account_revenue etc. are not required, while the accounts are now required even
if they are defined on the category and 'use accounts from category' is marked.