Added support for associating functions with extensions and performing valida...

Added support for associating functions with extensions and performing validation when those functions are used in a shader.
BUG=25

[kbr1, 2010-09-08 19:04:52]

LGTM with a couple of minor comments.

http://codereview.appspot.com/2141046/diff/1/src/compiler/ParseHelper.cpp
File src/compiler/ParseHelper.cpp (right):

http://codereview.appspot.com/2141046/diff/1/src/compiler/ParseHelper.cpp#new...
src/compiler/ParseHelper.cpp:890: if (iter == extensionBehavior.end()) {
Extraneous whitespace

http://codereview.appspot.com/2141046/diff/1/src/compiler/SymbolTable.cpp
File src/compiler/SymbolTable.cpp (right):

http://codereview.appspot.com/2141046/diff/1/src/compiler/SymbolTable.cpp#new...
src/compiler/SymbolTable.cpp:145: // to be related to the provided built-in
extension.
It's worth adding the same comment as for relateToOperator about this being low
performance.

http://codereview.appspot.com/2141046/diff/1/src/compiler/SymbolTable.h
File src/compiler/SymbolTable.h (right):

http://codereview.appspot.com/2141046/diff/1/src/compiler/SymbolTable.h#newco...
src/compiler/SymbolTable.h:299: assert(table.size() >= 2);
Lots of extraneous whitespace

[Alok Priyadarshi, 2010-09-08 19:14:31]

http://codereview.appspot.com/2141046/diff/1/src/compiler/ParseHelper.cpp
File src/compiler/ParseHelper.cpp (right):

http://codereview.appspot.com/2141046/diff/1/src/compiler/ParseHelper.cpp#new...
src/compiler/ParseHelper.cpp:890: if (iter == extensionBehavior.end()) {
On 2010/09/08 19:04:52, kbr1 wrote:
> Extraneous whitespace
> 

this is just how reitveld is showing the diff. there is not extra whitespace.

http://codereview.appspot.com/2141046/diff/1/src/compiler/SymbolTable.cpp
File src/compiler/SymbolTable.cpp (right):

http://codereview.appspot.com/2141046/diff/1/src/compiler/SymbolTable.cpp#new...
src/compiler/SymbolTable.cpp:145: // to be related to the provided built-in
extension.
On 2010/09/08 19:04:52, kbr1 wrote:
> It's worth adding the same comment as for relateToOperator about this being
low
> performance.
> 

Done.

http://codereview.appspot.com/2141046/diff/1/src/compiler/SymbolTable.h
File src/compiler/SymbolTable.h (right):

http://codereview.appspot.com/2141046/diff/1/src/compiler/SymbolTable.h#newco...
src/compiler/SymbolTable.h:299: assert(table.size() >= 2);
On 2010/09/08 19:04:52, kbr1 wrote:
> Lots of extraneous whitespace
> 

ditto.

[dgkoch, 2010-09-09 13:08:40]

A couple of comments about TParseContext::extensionErrorCheck.

The rest looks fine.

Daniel

http://codereview.appspot.com/2141046/diff/7001/src/compiler/ParseHelper.cpp
File src/compiler/ParseHelper.cpp (right):

http://codereview.appspot.com/2141046/diff/7001/src/compiler/ParseHelper.cpp#...
src/compiler/ParseHelper.cpp:887: bool TParseContext::extensionErrorCheck(int
line, const TString& extension)
The extension type here can also be EBhRequire or EBhEnable, but the function
doesn't assert or handle on these cases.

http://codereview.appspot.com/2141046/diff/7001/src/compiler/ParseHelper.cpp#...
src/compiler/ParseHelper.cpp:891: error(line, "extension", extension.c_str(),
"is not supported");
You probably want to add spaces around the extension name in the log to make
this more readable.

http://codereview.appspot.com/2141046/diff/7001/src/compiler/ParseHelper.cpp#...
src/compiler/ParseHelper.cpp:895: error(line, "extension", extension.c_str(),
"is disabled");
again need more spaces in the string literals.

[Alok Priyadarshi, 2010-09-09 17:29:46]

http://codereview.appspot.com/2141046/diff/7001/src/compiler/ParseHelper.cpp
File src/compiler/ParseHelper.cpp (right):

http://codereview.appspot.com/2141046/diff/7001/src/compiler/ParseHelper.cpp#...
src/compiler/ParseHelper.cpp:887: bool TParseContext::extensionErrorCheck(int
line, const TString& extension)
because they are not error or warning cases.

http://codereview.appspot.com/2141046/diff/7001/src/compiler/ParseHelper.cpp#...
src/compiler/ParseHelper.cpp:891: error(line, "extension", extension.c_str(),
"is not supported");
On 2010/09/09 13:08:40, dgkoch wrote:
> You probably want to add spaces around the extension name in the log to make
> this more readable.

space is added by the error function.

http://codereview.appspot.com/2141046/diff/7001/src/compiler/ParseHelper.cpp#...
src/compiler/ParseHelper.cpp:895: error(line, "extension", extension.c_str(),
"is disabled");
On 2010/09/09 13:08:40, dgkoch wrote:
> again need more spaces in the string literals.

ditto