Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(823)

Issue 2140041: Build: un-nodify markup-*-commands.tely (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by Graham Percival (old account)
Modified:
13 years, 7 months ago
Reviewers:
carl.d.sorensen, c_sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Build: un-nodify markup-*-commands.tely

Patch Set 1 #

Patch Set 2 : Use output port -> string #

Total comments: 1

Patch Set 3 : Gives calculation of magic number. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -98 lines) Patch
M Documentation/de/notation/notation-appendices.itely View 1 2 2 chunks +13 lines, -18 lines 0 comments Download
M Documentation/es/notation/notation-appendices.itely View 1 2 2 chunks +13 lines, -18 lines 0 comments Download
M Documentation/fr/notation/notation-appendices.itely View 1 2 2 chunks +8 lines, -18 lines 0 comments Download
M Documentation/notation/notation-appendices.itely View 1 2 chunks +11 lines, -18 lines 0 comments Download
M scm/document-markup.scm View 1 2 chunks +13 lines, -20 lines 0 comments Download
M scm/documentation-generate.scm View 1 2 1 chunk +15 lines, -6 lines 0 comments Download

Messages

Total messages: 4
Graham Percival (old account)
This isn't a miracle of clean scheme, but I don't think it's completely horrible, gets ...
13 years, 7 months ago (2010-09-03 17:17:22 UTC) #1
Carl
Looks acceptable to me, with one slight change if it's possible. THanks, Carl http://codereview.appspot.com/2140041/diff/2001/3006 File ...
13 years, 7 months ago (2010-09-03 17:41:37 UTC) #2
Graham Percival (old account)
On 2010/09/03 17:41:37, Carl wrote: > scm/documentation-generate.scm:56: ;; magic number to remove the initial part ...
13 years, 7 months ago (2010-09-03 18:01:28 UTC) #3
c_sorensen
13 years, 7 months ago (2010-09-03 18:36:10 UTC) #4
LGTM.

Carl


On 9/3/10 12:01 PM, "percival.music.ca@gmail.com"
<percival.music.ca@gmail.com> wrote:

> On 2010/09/03 17:41:37, Carl wrote:
>> scm/documentation-generate.scm:56: ;; magic number to remove the
> initial part
>> Can we have something in the comment that says what would have to
> change in
>> order to change the magic number?
> 
> Thanks for the comment; done.  I should have done this math to begin
> with, instead of determining it via experimental error.  :)
> 
> Cheers,
> - Graham
> 
> http://codereview.appspot.com/2140041/

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b