Issue 2137048: code review 2137048: build: clear custom variables like GREP_OPTIONS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2137048: code review 2137048: build: clear custom variables like GREP_OPTIONS (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by rsc

Modified:
14 years, 9 months ago

Reviewers:

CC:
r, r2, golang-dev

Visibility:
Public.

Description

build: clear custom variables like GREP_OPTIONS Fixes issue 946.

Patch Set 1 #

Patch Set 2 : code review 2137048: build: clear custom variables like GREP_OPTIONS #

Patch Set 3 : code review 2137048: build: clear custom variables like GREP_OPTIONS #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	src/Make.inc	View	1	2 chunks	+13 lines, -0 lines	0 comments	Download
	M	src/pkg/deps.bash	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 9 months ago (2010-09-29 03:00:15 UTC) #1

LGTM gotta love Linux. all those features sure make things nicer

14 years, 9 months ago (2010-09-29 03:47:47 UTC) #2

rsc

14 years, 9 months ago (2010-09-29 03:51:57 UTC) #3

*** Submitted as 62e818802d13 ***

build: clear custom variables like GREP_OPTIONS

Fixes issue 946.

R=r, r2
CC=golang-dev
http://codereview.appspot.com/2137048

Expand All Messages | Collapse All Messages