Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2485)

Issue 21370043: Allow \partial to occur in mid-piece (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by dak
Modified:
8 years, 9 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allow \partial to occur in mid-piece This is done by moving measurePosition to negative values when at the beginning of a measure, and to a respective distance before the end of the measure in case the measure has already been started. Also: Document in-piece use of \partial

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make robust against multiple calls of \partial in a row #

Patch Set 3 : Allow for multiple calls (really), better ties to Timing. #

Patch Set 4 : Look for "Timing" alias after all #

Patch Set 5 : Make bar number overrides even more complex nbut much more useful #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -27 lines) Patch
M Documentation/notation/rhythms.itely View 1 2 3 4 2 chunks +24 lines, -19 lines 0 comments Download
M lily/partial-iterator.cc View 1 2 3 1 chunk +28 lines, -8 lines 0 comments Download

Messages

Total messages: 6
pkx166h
https://codereview.appspot.com/21370043/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/21370043/diff/1/Documentation/notation/rhythms.itely#newcode1458 Documentation/notation/rhythms.itely:1458: #end-of-line-invisible Is there perhaps a better way to illustrate ...
10 years, 5 months ago (2013-11-03 17:04:27 UTC) #1
dak
Make robust against multiple calls of \partial in a row
10 years, 5 months ago (2013-11-03 19:33:22 UTC) #2
dak
Allow for multiple calls (really), better ties to Timing.
10 years, 5 months ago (2013-11-04 14:41:26 UTC) #3
dak
Look for "Timing" alias after all
10 years, 5 months ago (2013-11-04 16:12:58 UTC) #4
dak
https://codereview.appspot.com/21370043/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/21370043/diff/1/Documentation/notation/rhythms.itely#newcode1458 Documentation/notation/rhythms.itely:1458: #end-of-line-invisible On 2013/11/03 17:04:28, J_lowe wrote: > Is there ...
10 years, 5 months ago (2013-11-04 17:24:41 UTC) #5
dak
10 years, 5 months ago (2013-11-04 17:41:58 UTC) #6
Make bar number overrides even more complex nbut much more useful
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b